Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-08 Thread Stefan Roese
On Tuesday 08 January 2008, Sean MacLennan wrote: > Let's try again. Looks good now. Time to send it to the i2c mailing list <[EMAIL PROTECTED]> and the maintainer Jean Delvare <[EMAIL PROTECTED]>. And please keep the linuxppc-dev list on CC. Thanks. Ciao, Stefan __

Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-08 Thread Sean MacLennan
Let's try again. Cheers, Sean diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index c466c6c..e9e1493 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -241,7 +241,6 @@ config I2C_PIIX4 config I2C_IBM_IIC tristate "IBM PPC 4xx on-chip I

Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-08 Thread Scott Wood
On Tue, Jan 08, 2008 at 12:56:27AM -0500, Sean MacLennan wrote: > Stephen Rothwell wrote: > > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > >> +static int __devinit iic_probe(struct of_device *ofdev, > >> + const s

Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-07 Thread Stephen Rothwell
On Tue, 08 Jan 2008 00:56:27 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > > > > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > > Please don't post patches as attachments. > > Ok. Unfortunately, you are using thunderbird and

Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-07 Thread Sean MacLennan
Stephen Rothwell wrote: > Hi Sean, > > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > Please don't post patches as attachments. > Ok. > >> +static int __devinit iic_probe(struct of_device *ofdev, >> +

Re: [PATCH] i2c-ibm_iic driver - new patch

2008-01-07 Thread Stephen Rothwell
Hi Sean, On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > Please don't post patches as attachments. > +static int __devinit iic_probe(struct of_device *ofdev, > +const struct > of_device_id *match) Indenting

[PATCH] i2c-ibm_iic driver - new patch

2008-01-07 Thread Sean MacLennan
Second attempt. I think I have covered all the comments. It now should work with both ppc and powerpc architectures. You can now specify fast-mode in the .dts file. You can now specify an index for each entry. If you don't I try to chose reasonable defaults. i.e. I keep a static int that is i