Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-10 Thread Anton Vorontsov
On Thu, Jun 10, 2010 at 12:22:26PM +0200, Richard Cochran wrote: [...] > > U-Boot 1.1.6 (Oct 9 2007 - 20:42:39) MPC83XX > ... > > CPU: MPC8313E, Rev: 10 at 333.333 MHz > > We have a newer CPU revision: > >U-Boot 1.3.0 (Dec 23 2008 - 13:38:14) MPC83XX >CPU: e300c3, MPC8313E, Rev: 21 at

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-10 Thread Richard Cochran
On Thu, Jun 10, 2010 at 01:31:59PM +0400, Anton Vorontsov wrote: > > No, we did not set TMR_CTRL[TE]. > > So, you deliberately violate the spec and expect it to work > everywhere? :-) Sometimes one must read the manual with a grain of salt ;) > > > Also, I recall that Freescale BSPs were explici

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-10 Thread Anton Vorontsov
On Thu, Jun 10, 2010 at 08:29:08AM +0200, Richard Cochran wrote: > On Wed, Jun 09, 2010 at 11:32:19PM +0400, Anton Vorontsov wrote: > > Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add > > hardware RX timestamping support"), the driver no longer works on > > at least MPC8313ERDB

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-09 Thread Richard Cochran
On Wed, Jun 09, 2010 at 11:32:19PM +0400, Anton Vorontsov wrote: > Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add > hardware RX timestamping support"), the driver no longer works on > at least MPC8313ERDB and MPC8568EMDS boards (and possibly much more > boards as well). What

Re: [PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-09 Thread David Miller
From: Anton Vorontsov Date: Wed, 9 Jun 2010 23:32:19 +0400 > Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add > hardware RX timestamping support"), the driver no longer works on > at least MPC8313ERDB and MPC8568EMDS boards (and possibly much more > boards as well). > > That'

[PATCH] gianfar: Revive the driver for eTSEC devices (disable timestamping)

2010-06-09 Thread Anton Vorontsov
Since commit cc772ab7cdcaa24d1fae332d92a1602788644f7a ("gianfar: Add hardware RX timestamping support"), the driver no longer works on at least MPC8313ERDB and MPC8568EMDS boards (and possibly much more boards as well). That's how MPC8313 Reference Manual describes RCTRL_TS_ENABLE bit: Timestam