Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Alex Dubov
> > -        > gfar_tx_checksum(skb, fcb); > > +        switch > (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)) > > +        >     ? 1 : 0) { > > The switch construction is quite bizarre. ;-) Why not > My testing shows that even on broken chips unaligned packets are quite rare (only some SYN p

Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread David Miller
Please CC: netdev on future submissions of this patch, otherwise I won't see it in my queue. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Anton Vorontsov
Hello Alex, On Thu, Jan 27, 2011 at 12:14:21AM -0800, Alex Dubov wrote: > As specified by errata eTSEC49 of MPC8548 and errata eTSEC12 of MPC83xx, > older revisions of gianfar controllers will be unable to calculate a TCP/UDP > packet checksum for some aligments of the appropriate FCB. This patch

[PATCH] gianfar: Fall back to software tcp/udp checksum on older controllers

2011-01-27 Thread Alex Dubov
As specified by errata eTSEC49 of MPC8548 and errata eTSEC12 of MPC83xx, older revisions of gianfar controllers will be unable to calculate a TCP/UDP packet checksum for some aligments of the appropriate FCB. This patch checks for FCB alignment on such controllers and falls back to software checksu