Re: [PATCH] futex: improve user space accesses

2024-12-09 Thread Andreas Schwab
On Dez 08 2024, Linus Torvalds wrote: > IOW, does this one-liner fix it for you? > > --- a/kernel/futex/futex.h > +++ b/kernel/futex/futex.h > @@ -265,7 +265,7 @@ > else if (!user_read_access_begin(from, sizeof(*from))) > return -EFAULT; > unsafe_get_user(val,

Re: [PATCH] futex: improve user space accesses

2024-12-09 Thread Christophe Leroy
Le 09/12/2024 à 01:32, Linus Torvalds a écrit : On Sun, 8 Dec 2024 at 14:54, Andreas Schwab wrote: This breaks userspace on ppc32. As soon as /init in the initrd is started the kernel hangs (without any messages). Funky, funky. Most of the diff is the code movement (and some small x86-sp

Re: [PATCH] futex: improve user space accesses

2024-12-08 Thread Linus Torvalds
On Sun, 8 Dec 2024 at 14:54, Andreas Schwab wrote: > > This breaks userspace on ppc32. As soon as /init in the initrd is > started the kernel hangs (without any messages). Funky, funky. Most of the diff is the code movement (and some small x86-specific stuff), so for ppc, the only part that shou

Re: [PATCH] futex: improve user space accesses

2024-12-08 Thread Andreas Schwab
On Nov 22 2024, Linus Torvalds wrote: > Josh Poimboeuf reports that he got a "will-it-scale.per_process_ops 1.9% > improvement" report for his patch that changed __get_user() to use > pointer masking instead of the explicit speculation barrier. However, > that patch doesn't actually work in the g