Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-10 Thread Steven Rostedt
ux/commits/Steven-Rostedt/ftrace-Make-ftrace_regs-abstract-from-direct-use/20241008-084930 > base: next-20241004 > patch link: > https://lore.kernel.org/r/20241007204743.41314f1d%40gandalf.local.home > patch subject: [PATCH] ftrace: Make ftrace_regs abstract from direct use > co

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-10 Thread kernel test robot
se: next-20241004 patch link: https://lore.kernel.org/r/20241007204743.41314f1d%40gandalf.local.home patch subject: [PATCH] ftrace: Make ftrace_regs abstract from direct use config: um-allnoconfig (https://download.01.org/0day-ci/archive/20241011/202410110707.uhvgl9s7-...@intel.com/config) compi

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-10 Thread kernel test robot
se: next-20241004 patch link: https://lore.kernel.org/r/20241007204743.41314f1d%40gandalf.local.home patch subject: [PATCH] ftrace: Make ftrace_regs abstract from direct use config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20241011/202410110707.oaei6wyh-...@intel.com/config

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Steven Rostedt
On Wed, 9 Oct 2024 07:41:40 +0900 Masami Hiramatsu (Google) wrote: > Hi Steve, > > > diff --git a/include/asm-generic/ftrace.h b/include/asm-generic/ftrace.h > > index 3a23028d69d2..ba7b7d6e55d6 100644 > > --- a/include/asm-generic/ftrace.h > > +++ b/include/asm-generic/ftrace.h > > @@ -10,4 +1

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Google
Hi Steve, > diff --git a/include/asm-generic/ftrace.h b/include/asm-generic/ftrace.h > index 3a23028d69d2..ba7b7d6e55d6 100644 > --- a/include/asm-generic/ftrace.h > +++ b/include/asm-generic/ftrace.h > @@ -10,4 +10,17 @@ > * common definitions are already in linux/ftrace.h. > */ > > +#ifnd

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Heiko Carstens
On Mon, Oct 07, 2024 at 08:54:58PM -0400, Steven Rostedt wrote: > On Mon, 7 Oct 2024 20:47:43 -0400 > Steven Rostedt wrote: > #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs)->regs; }) > > I may send a v2 (tomorrow). Could you also write against which tree this patch is? It does

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Steven Rostedt
On Tue, 8 Oct 2024 08:24:22 +0200 Christophe Leroy wrote: > >> + > >> +struct ftrace_regs; > >> +#define arch_ftrace_regs(fregs) ((struct __arch_ftrace_regs *)(fregs)) > >> + > > > > I just realized I can simplify it with: > > > > #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Steven Rostedt
On Tue, 8 Oct 2024 16:58:52 +0200 Heiko Carstens wrote: > On Mon, Oct 07, 2024 at 08:54:58PM -0400, Steven Rostedt wrote: > > On Mon, 7 Oct 2024 20:47:43 -0400 > > Steven Rostedt wrote: > > #define arch_ftrace_get_regs(fregs) ({ &arch_ftrace_regs(fregs)->regs; }) > > > > I may send a v2 (tomorr

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-08 Thread Catalin Marinas
On Mon, Oct 07, 2024 at 08:47:43PM -0400, Steven Rostedt wrote: > From: Steven Rostedt > > ftrace_regs was created to hold registers that store information to save > function parameters, return value and stack. Since it is a subset of > pt_regs, it should only be used by its accessor functions. B

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-07 Thread Christophe Leroy
Le 08/10/2024 à 02:54, Steven Rostedt a écrit : On Mon, 7 Oct 2024 20:47:43 -0400 Steven Rostedt wrote: +#ifndef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS +struct __arch_ftrace_regs { + struct pt_regs regs; +}; + +#define arch_ftrace_get_regs(fregs)

Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-07 Thread Steven Rostedt
On Mon, 7 Oct 2024 20:47:43 -0400 Steven Rostedt wrote: > +#ifndef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS > +struct __arch_ftrace_regs { > + struct pt_regs regs; > +}; > + > +#define arch_ftrace_get_regs(fregs) \ > + ({ struct __arch_fregs_regs *__f

[PATCH] ftrace: Make ftrace_regs abstract from direct use

2024-10-07 Thread Steven Rostedt
From: Steven Rostedt ftrace_regs was created to hold registers that store information to save function parameters, return value and stack. Since it is a subset of pt_regs, it should only be used by its accessor functions. But because pt_regs can easily be taken from ftrace_regs (on most archs), i