Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Benjamin Herrenschmidt
On Mon, 2009-02-09 at 10:40 +0100, Ingo Molnar wrote: > * Steven Rostedt wrote: > > > > > Paul, > > > > I found the bug that was causing large modules to fail in setting > > up dynamic ftrace. It wound up being a simple math error. To calculate > > the offset in the TOC, I had used an OR, but t

Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Geoff Levand
Steven Rostedt wrote: > I found the bug that was causing large modules to fail in setting > up dynamic ftrace. It wound up being a simple math error. To calculate > the offset in the TOC, I had used an OR, but the bottom half was > a signed extended short, and it should have been an addition. > The

Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Remis Lima Baima
I have just tried the patch here and everything worked great! Very well done. On Mon, Feb 9, 2009 at 10:40 AM, Ingo Molnar wrote: > > * Steven Rostedt wrote: > >> >> Paul, >> >> I found the bug that was causing large modules to fail in setting >> up dynamic ftrace. It wound up being a simple mat

Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Ingo Molnar
* Steven Rostedt wrote: > > On Mon, 9 Feb 2009, Ingo Molnar wrote: > > > > > * Steven Rostedt wrote: > > > > > > > > Paul, > > > > > > I found the bug that was causing large modules to fail in setting > > > up dynamic ftrace. It wound up being a simple math error. To calculate > > > the o

Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Steven Rostedt
On Mon, 9 Feb 2009, Ingo Molnar wrote: > > * Steven Rostedt wrote: > > > > > Paul, > > > > I found the bug that was causing large modules to fail in setting > > up dynamic ftrace. It wound up being a simple math error. To calculate > > the offset in the TOC, I had used an OR, but the bottom

Re: [PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-09 Thread Ingo Molnar
* Steven Rostedt wrote: > > Paul, > > I found the bug that was causing large modules to fail in setting > up dynamic ftrace. It wound up being a simple math error. To calculate > the offset in the TOC, I had used an OR, but the bottom half was > a signed extended short, and it should have been

[PATCH] ftrace, powerpc64: fix math to calculate offset in TOC

2009-02-07 Thread Steven Rostedt
Paul, I found the bug that was causing large modules to fail in setting up dynamic ftrace. It wound up being a simple math error. To calculate the offset in the TOC, I had used an OR, but the bottom half was a signed extended short, and it should have been an addition. The fix is in my tree below