Re: [PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-18 Thread Kumar Gala
On Mon, 14 Jan 2008, Scott Wood wrote: > The reg property in fsl soc nodes should be removed. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/fsl_soc.c | 14 +++--- > 1 files changed, 11 insertions(+), 3 deletions(-) applied. (dropped the size == 12 check

Re: [PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-15 Thread Scott Wood
Kumar Gala wrote: >> Why go out of our way to fail on a childless soc node? > > do we see any case in which we'd have a childless soc node? It's possible that it could be used to communicate immrbase and soc type, but nothing else. Not overly likely, but possible. > I'm just concerned about ma

Re: [PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-15 Thread Kumar Gala
On Jan 15, 2008, at 10:40 AM, Scott Wood wrote: > On Mon, Jan 14, 2008 at 08:37:27PM -0600, Kumar Gala wrote: >>> diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/ >>> fsl_soc.c >>> index 3ace747..7502e03 100644 >>> --- a/arch/powerpc/sysdev/fsl_soc.c >>> +++ b/arch/powerpc/sysdev

Re: [PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-15 Thread Scott Wood
On Mon, Jan 14, 2008 at 08:37:27PM -0600, Kumar Gala wrote: > >diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/ > >fsl_soc.c > >index 3ace747..7502e03 100644 > >--- a/arch/powerpc/sysdev/fsl_soc.c > >+++ b/arch/powerpc/sysdev/fsl_soc.c > >@@ -54,10 +54,18 @@ phys_addr_t get_immrba

Re: [PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-14 Thread Kumar Gala
On Jan 14, 2008, at 10:29 AM, Scott Wood wrote: > The reg property in fsl soc nodes should be removed. > > Signed-off-by: Scott Wood <[EMAIL PROTECTED]> > --- > arch/powerpc/sysdev/fsl_soc.c | 14 +++--- > 1 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/sy

[PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-14 Thread Scott Wood
The reg property in fsl soc nodes should be removed. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c index 3ace747..

[PATCH] fsl_soc: Fix get_immrbase() to use ranges, rather than reg.

2008-01-11 Thread Scott Wood
The reg property in fsl soc nodes should be removed. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c index 3ace747..