Re: [PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Benjamin Herrenschmidt
On Tue, 2010-03-30 at 15:02 -0700, Feng Kan wrote: > Ok thanks. This short string match may be useful in some cases, but I > agree it plays havoc with the current code. Yeah well, it's not actually -that- useful and is definitely broken :-) If you want multiples matches, then it's the compatible

Re: [PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Grant Likely
On Tue, Mar 30, 2010 at 3:14 PM, Benjamin Herrenschmidt wrote: > On Wed, 2010-03-31 at 07:48 +1100, Benjamin Herrenschmidt wrote: >> On Tue, 2010-03-30 at 10:41 -0700, Feng Kan wrote: >> > From: Feng Kan >> > >> > The current matching scheme make the pci node match to pcix or pciex node. >> > To

Re: [PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Feng Kan
Ok thanks. This short string match may be useful in some cases, but I agree it plays havoc with the current code. Feng Kan On Mar 30, 2010, at 14:14, "Benjamin Herrenschmidt" > wrote: On Wed, 2010-03-31 at 07:48 +1100, Benjamin Herrenschmidt wrote: On Tue, 2010-03-30 at 10:41 -0700, Feng K

Re: [PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Benjamin Herrenschmidt
On Wed, 2010-03-31 at 07:48 +1100, Benjamin Herrenschmidt wrote: > On Tue, 2010-03-30 at 10:41 -0700, Feng Kan wrote: > > From: Feng Kan > > > > The current matching scheme make the pci node match to pcix or pciex node. > > To avoid the match, change the method so only one type of initialization

Re: [PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Benjamin Herrenschmidt
On Tue, 2010-03-30 at 10:41 -0700, Feng Kan wrote: > From: Feng Kan > > The current matching scheme make the pci node match to pcix or pciex node. > To avoid the match, change the method so only one type of initialization > is called per node. No, your patch is not right. The problem was introdu

[PATCH] fix the problem where pcix node is probed again as pci node.

2010-03-30 Thread Feng Kan
From: Feng Kan The current matching scheme make the pci node match to pcix or pciex node. To avoid the match, change the method so only one type of initialization is called per node. Signed-off-by: Feng Kan Signed-off-by: Tirumala R Marri --- arch/powerpc/sysdev/ppc4xx_pci.c | 14 --