Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-14 Thread Grant Likely
On Wed, 05 Jun 2013 10:50:02 -0600, Stephen Warren wrote: > On 06/03/2013 09:36 AM, Stephen Warren wrote: > > From: Stephen Warren > > > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > > could match line-break characters. If the #line directive did not contain > > th

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-05 Thread Stephen Warren
On 06/03/2013 09:36 AM, Stephen Warren wrote: > From: Stephen Warren > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > could match line-break characters. If the #line directive did not contain > the optional flags field at the end, this could cause any integer data on

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Ian Campbell
On Mon, 2013-06-03 at 09:36 -0600, Stephen Warren wrote: > From: Stephen Warren > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > could match line-break characters. If the #line directive did not contain > the optional flags field at the end, this could cause any integ

[PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line direct

Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

2013-05-31 Thread Stephen Warren
On 05/31/2013 11:38 AM, Andreas Schwab wrote: > Stephen Warren writes: > >> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks. > > I think the other uses of {WS} shouldn't span lines either. That is true, but only the optional occurrence /should/ matter. Any changes to th

Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

2013-05-31 Thread Andreas Schwab
Stephen Warren writes: > Fix this by replacing {WS} with [ \t] so that it can't match line-breaks. I think the other uses of {WS} shouldn't span lines either. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now fo

[PATCH] dtc: Ensure #line directives don't consume data from the next line

2013-05-31 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line direct