Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-06 Thread Chen Gang
于 2013年03月07日 14:05, Benjamin Herrenschmidt 写道: > On Thu, 2013-03-07 at 12:34 +0800, Chen Gang wrote: >> > oh, this patch has integrated into next-20130307 tree. >> > (commit 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b) >> > it seems we need a regression for this commit, then I send patch v2 >

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-06 Thread Benjamin Herrenschmidt
On Thu, 2013-03-07 at 12:34 +0800, Chen Gang wrote: > oh, this patch has integrated into next-20130307 tree. > (commit 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b) > it seems we need a regression for this commit, then I send patch v2 > > is it correct ? Just send a fixup patch on top of th

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-06 Thread Chen Gang
oh, this patch has integrated into next-20130307 tree. (commit 9276dfd27897a0b29d8b5814f39a1f82f56b6b6b) it seems we need a regression for this commit, then I send patch v2 is it correct ? :-) 于 2013年03月07日 12:10, Chen Gang 写道: > 于 2013年03月05日 17:36, Jiri Slaby 写道: >> On 03/05/2013

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-06 Thread Chen Gang
于 2013年03月05日 17:36, Jiri Slaby 写道: > On 03/05/2013 02:58 AM, Chen Gang wrote: >> > 于 2013年02月28日 21:47, Jiri Slaby 写道: > when strlen(&pi->location_code[0]) == HVCS_CLC_LENGTH + 2 >>> >> It cannot, pi->location_code is defined as char[HVCS_CLC_LENGTH + 1]. >>> >> >> > >> > really, it

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-05 Thread Jiri Slaby
On 03/05/2013 02:58 AM, Chen Gang wrote: > 于 2013年02月28日 21:47, Jiri Slaby 写道: when strlen(&pi->location_code[0]) == HVCS_CLC_LENGTH + 2 >> It cannot, pi->location_code is defined as char[HVCS_CLC_LENGTH + 1]. >> > > really, it is, I did not notice it. > > but I still prefer to modify

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-03-04 Thread Chen Gang
于 2013年02月28日 21:47, Jiri Slaby 写道: >>> when strlen(&pi->location_code[0]) == HVCS_CLC_LENGTH + 2 > It cannot, pi->location_code is defined as char[HVCS_CLC_LENGTH + 1]. > really, it is, I did not notice it. but I still prefer to modify it, but the patch should be changed such as: su

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-02-28 Thread Jiri Slaby
On 02/28/2013 12:15 PM, Chen Gang wrote: > 于 2013年02月28日 19:13, Chen Gang 写道: >> 于 2013年02月28日 18:41, Jiri Slaby 写道: >>> On 02/26/2013 04:43 AM, Chen Gang wrote: > > when strlen pi->location_code is larger than HVCS_CLC_LENGTH + 1, > original implementation can not let hvcsd->p_lo

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-02-28 Thread Chen Gang
于 2013年02月28日 19:13, Chen Gang 写道: > 于 2013年02月28日 18:41, Jiri Slaby 写道: >> On 02/26/2013 04:43 AM, Chen Gang wrote: when strlen pi->location_code is larger than HVCS_CLC_LENGTH + 1, original implementation can not let hvcsd->p_location_code NUL terminated. so need

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-02-28 Thread Chen Gang
于 2013年02月28日 18:41, Jiri Slaby 写道: > On 02/26/2013 04:43 AM, Chen Gang wrote: >> > >> > when strlen pi->location_code is larger than HVCS_CLC_LENGTH + 1, >> > original implementation can not let hvcsd->p_location_code NUL >> > terminated. >> > so need fix it (also can simplify the code)

Re: [PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-02-28 Thread Jiri Slaby
On 02/26/2013 04:43 AM, Chen Gang wrote: > > when strlen pi->location_code is larger than HVCS_CLC_LENGTH + 1, > original implementation can not let hvcsd->p_location_code NUL terminated. > so need fix it (also can simplify the code) It should never be larger because the +1 is exactly for

[PATCH] drivers/tty/hvc: using strlcpy instead of strncpy

2013-02-25 Thread Chen Gang
when strlen pi->location_code is larger than HVCS_CLC_LENGTH + 1, original implementation can not let hvcsd->p_location_code NUL terminated. so need fix it (also can simplify the code) Signed-off-by: Chen Gang --- drivers/tty/hvc/hvcs.c |9 ++--- 1 files changed, 2 insertions(+)