Re: [PATCH] cxl: use correct operator when writing pcie config space values

Andrew Donnellan writes: > On 06/11/15 10:43, Michael Ellerman wrote: >> If it's unused *and* broken then we should just remove it. > > Following some discussion with Ian and Vaibhav, we'd like to keep it at > this stage - while there are no current AFUs which write to AFU config > space, it wo

Re: [PATCH] cxl: use correct operator when writing pcie config space values

On 06/11/15 10:43, Michael Ellerman wrote: If it's unused *and* broken then we should just remove it. Following some discussion with Ian and Vaibhav, we'd like to keep it at this stage - while there are no current AFUs which write to AFU config space, it would be reasonable for an AFU develop

Re: [PATCH] cxl: use correct operator when writing pcie config space values

On Fri, 2015-11-06 at 10:05 +1100, Daniel Axtens wrote: > Andrew Donnellan writes: > > > When writing a value to config space, cxl_pcie_write_config() calls > > cxl_pcie_config_info() to obtain a mask and shift value, shifts the new > > value accordingly, then uses the mask to combine the shift

Re: [PATCH] cxl: use correct operator when writing pcie config space values

On 06/11/15 10:05, Daniel Axtens wrote: Given that there are no current users of this function, does this need to go to stable? Does it actually fix a real (as opposed to theoretical) bug? I tagged it for stable on mpe's request - I'm not fussed either way. Andrew -- Andrew Donnellan

Re: [PATCH] cxl: use correct operator when writing pcie config space values

On Fri, 2015-11-06 at 10:05 +1100, Daniel Axtens wrote: > Andrew Donnellan writes: > > > When writing a value to config space, cxl_pcie_write_config() calls > > cxl_pcie_config_info() to obtain a mask and shift value, shifts the > > new > > value accordingly, then uses the mask to combine the shi

Re: [PATCH] cxl: use correct operator when writing pcie config space values

Andrew Donnellan writes: > When writing a value to config space, cxl_pcie_write_config() calls > cxl_pcie_config_info() to obtain a mask and shift value, shifts the new > value accordingly, then uses the mask to combine the shifted value with the > existing value at the address as part of a read-

Re: [PATCH] cxl: use correct operator when writing pcie config space values

Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] cxl: use correct operator when writing pcie config space values

When writing a value to config space, cxl_pcie_write_config() calls cxl_pcie_config_info() to obtain a mask and shift value, shifts the new value accordingly, then uses the mask to combine the shifted value with the existing value at the address as part of a read-modify-write pattern. Currently, w