Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-12-08 Thread Michael Ellerman
On Wed, 2015-12-09 at 12:00 +1100, Michael Neuling wrote: > On Tue, 2015-12-08 at 17:30 +1100, Andrew Donnellan wrote: > > Finally looking at this patch again for the first time in a couple of > > months... > > > > On 04/11/15 17:17, Andrew Donnellan wrote: > > > On 03/11/15 20:09, Michael Ellerma

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-12-08 Thread Michael Neuling
On Tue, 2015-12-08 at 17:30 +1100, Andrew Donnellan wrote: > Finally looking at this patch again for the first time in a couple of > months... > > On 04/11/15 17:17, Andrew Donnellan wrote: > > On 03/11/15 20:09, Michael Ellerman wrote: > > > Part of your problem is you're storing afu->crs_len whi

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-12-07 Thread Andrew Donnellan
Finally looking at this patch again for the first time in a couple of months... On 04/11/15 17:17, Andrew Donnellan wrote: On 03/11/15 20:09, Michael Ellerman wrote: Part of your problem is you're storing afu->crs_len which is not __iomem in cfg_data which is, and so that's leading to some of

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-11-03 Thread Andrew Donnellan
On 03/11/15 20:09, Michael Ellerman wrote: Part of your problem is you're storing afu->crs_len which is not __iomem in cfg_data which is, and so that's leading to some of your casts. I don't really see why you're using cfg_data like that, you have the afu in phb->private_data. But maybe cfg_data

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-11-03 Thread Michael Ellerman
On Wed, 2015-10-28 at 14:29 +1100, Andrew Donnellan wrote: > sparse identifies the following issues: > > drivers/misc/cxl/vphb.c:131:17: warning: incorrect type in assignment > (different address spaces) > drivers/misc/cxl/vphb.c:131:17:expected void volatile [noderef] > * > dri

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-11-01 Thread Andrew Donnellan
On 31/10/15 00:07, Arnd Bergmann wrote: On Wednesday 28 October 2015 14:29:39 Andrew Donnellan wrote: --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -128,7 +128,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn, return PCIBIOS_BAD_REGI

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-10-30 Thread Arnd Bergmann
On Wednesday 28 October 2015 14:29:39 Andrew Donnellan wrote: > --- a/drivers/misc/cxl/vphb.c > +++ b/drivers/misc/cxl/vphb.c > @@ -128,7 +128,7 @@ static int cxl_pcie_config_info(struct pci_bus *bus, > unsigned int devfn, > return PCIBIOS_BAD_REGISTER_NUMBER; > addr = cxl_

Re: [PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-10-27 Thread Ian Munsie
Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] cxl: sparse: add __iomem annotations in vphb.c

2015-10-27 Thread Andrew Donnellan
sparse identifies the following issues: drivers/misc/cxl/vphb.c:131:17: warning: incorrect type in assignment (different address spaces) drivers/misc/cxl/vphb.c:131:17:expected void volatile [noderef] * drivers/misc/cxl/vphb.c:131:17:got void * drivers/misc/cxl/vphb.c:252:2