Re: [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults

2016-03-29 Thread Matthew R. Ochs
> On Mar 17, 2016, at 11:01 PM, Andrew Donnellan > wrote: > > When handling page faults, cxl_handle_page_fault() checks whether the page > should be accessible by userspace and have its _PAGE_USER access bit set. > _PAGE_USER should be set if the context's kernel flag isn't set, or if the > page

Re: [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults

2016-03-20 Thread Andrew Donnellan
On 18/03/16 17:30, Ian Munsie wrote: Excerpts from andrew.donnellan's message of 2016-03-18 15:01:21 +1100: Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards for userspace access") It doesn't fix that since there was no cxl kernel API support at the time, so this wasn't a reg

Re: [PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults

2016-03-20 Thread Ian Munsie
Excerpts from andrew.donnellan's message of 2016-03-18 15:01:21 +1100: > Fixes: f204e0b8cedd ("cxl: Driver code for powernv PCIe based cards for > userspace access") It doesn't fix that since there was no cxl kernel API support at the time, so this wasn't a regression - just something we missed wh

[PATCH] cxl: fix setting of _PAGE_USER bit when handling page faults

2016-03-19 Thread Andrew Donnellan
When handling page faults, cxl_handle_page_fault() checks whether the page should be accessible by userspace and have its _PAGE_USER access bit set. _PAGE_USER should be set if the context's kernel flag isn't set, or if the page falls outside of kernel memory. However, the check currently uses the