Re: [PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Ian Munsie
Excerpts from andrew.donnellan's message of 2016-11-23 18:06:59 +1100: > On 23/11/16 17:49, Ian Munsie wrote: > > Most of these look fine > > > >> -return debugfs_create_file(name, mode, parent, (void __force *)value, > >> &fops_io_x64); > >> +return debugfs_create_file_unsafe(name, mode,

Re: [PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Andrew Donnellan
On 23/11/16 17:49, Ian Munsie wrote: Most of these look fine -return debugfs_create_file(name, mode, parent, (void __force *)value, &fops_io_x64); +return debugfs_create_file_unsafe(name, mode, parent, + (void __force *)value, &fops_io_x64); Just wondering what t

Re: [PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Ian Munsie
Most of these look fine > -return debugfs_create_file(name, mode, parent, (void __force *)value, > &fops_io_x64); > +return debugfs_create_file_unsafe(name, mode, parent, > + (void __force *)value, &fops_io_x64); Just wondering what this one is about? Cheers, -Ian

Re: [PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Matthew R. Ochs
> On Nov 22, 2016, at 4:13 AM, Andrew Donnellan > wrote: > > Fix the following coccinelle warnings: > >drivers/misc/cxl/debugfs.c:46:0-23: WARNING: fops_io_x64 should be >defined with DEFINE_DEBUGFS_ATTRIBUTE >drivers/misc/cxl/guest.c:890:5-26: WARNING: Comparison to bool >d

Re: [PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Frederic Barrat
Le 22/11/2016 à 11:13, Andrew Donnellan a écrit : Fix the following coccinelle warnings: drivers/misc/cxl/debugfs.c:46:0-23: WARNING: fops_io_x64 should be defined with DEFINE_DEBUGFS_ATTRIBUTE drivers/misc/cxl/guest.c:890:5-26: WARNING: Comparison to bool drivers/misc/cxl/

[PATCH] cxl: fix coccinelle warnings

2016-11-22 Thread Andrew Donnellan
Fix the following coccinelle warnings: drivers/misc/cxl/debugfs.c:46:0-23: WARNING: fops_io_x64 should be defined with DEFINE_DEBUGFS_ATTRIBUTE drivers/misc/cxl/guest.c:890:5-26: WARNING: Comparison to bool drivers/misc/cxl/irq.c:107:3-23: WARNING: Assignment of bool to 0/1