Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread Frederic Barrat
Le 05/05/2017 à 07:34, Dan Carpenter a écrit : We should unlock if get_cxl_adapter() fails. Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter from a guest") Signed-off-by: Dan Carpenter Acked-by: Frederic Barrat Thanks! Fred diff --git a/drivers/misc/cxl/flas

Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread Andrew Donnellan
On 05/05/17 17:37, Dan Carpenter wrote: On Fri, May 05, 2017 at 05:14:15PM +1000, Andrew Donnellan wrote: sem is a global and it looks like it's intended to be held after device_open() returns and only released in device_close(), so this looks wrong. This doesn't affect the success path, it o

Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread Dan Carpenter
On Fri, May 05, 2017 at 09:23:02AM +0200, walter harms wrote: > > sem is a global and it looks like it's intended to be held after > > device_open() returns and only released in device_close(), so this looks > > wrong. > > > > the patch relates to the error path, do you expect a close() after the

Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread Dan Carpenter
On Fri, May 05, 2017 at 05:14:15PM +1000, Andrew Donnellan wrote: > sem is a global and it looks like it's intended to be held after > device_open() returns and only released in device_close(), so this looks > wrong. > This doesn't affect the success path, it only means that if device_open() fail

Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread walter harms
Am 05.05.2017 09:14, schrieb Andrew Donnellan: > On 05/05/17 15:34, Dan Carpenter wrote: >> We should unlock if get_cxl_adapter() fails. >> >> Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter >> from a guest") >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/misc/

Re: [PATCH] cxl: Unlock on error in probe

2017-05-05 Thread Andrew Donnellan
On 05/05/17 15:34, Dan Carpenter wrote: We should unlock if get_cxl_adapter() fails. Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter from a guest") Signed-off-by: Dan Carpenter diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c index 7c61c70ba3f6..37475abe

[PATCH] cxl: Unlock on error in probe

2017-05-04 Thread Dan Carpenter
We should unlock if get_cxl_adapter() fails. Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter from a guest") Signed-off-by: Dan Carpenter diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c index 7c61c70ba3f6..37475abea3e6 100644 --- a/drivers/misc/cxl/flash.c