Re: [PATCH] cxl: Flush PSL cache before resetting the adapter

2016-10-04 Thread Frederic Barrat
Hi Vaibhav, Le 04/10/2016 à 07:49, Vaibhav Jain a écrit : Hi Fred, Frederic Barrat writes: + /* the adapter is about to be reset, so ignore errors */ + cxl_data_cache_flush(adapter); + Will be a good idea if we return error and not let the reset to proceed, if cxl_data_cache_f

Re: [PATCH] cxl: Flush PSL cache before resetting the adapter

2016-10-03 Thread Vaibhav Jain
Hi Fred, Frederic Barrat writes: > > + /* the adapter is about to be reset, so ignore errors */ > + cxl_data_cache_flush(adapter); > + Will be a good idea if we return error and not let the reset to proceed, if cxl_data_cache_flush returns EBUSY as continuing again may cause the UE error

Re: [PATCH] cxl: Flush PSL cache before resetting the adapter

2016-10-03 Thread Ian Munsie
Acked-by: Ian Munsie

Re: [PATCH] cxl: Flush PSL cache before resetting the adapter

2016-10-03 Thread Andrew Donnellan
On 04/10/16 06:36, Frederic Barrat wrote: If the capi link is going down while the PSL owns a dirty cache line, any access from the host for that data could lead to an Unrecoverable IIRC, s/Unrecoverable/Uncorrectable/ Error. So when resetting the capi adapter through sysfs, make sure the PSL

[PATCH] cxl: Flush PSL cache before resetting the adapter

2016-10-03 Thread Frederic Barrat
If the capi link is going down while the PSL owns a dirty cache line, any access from the host for that data could lead to an Unrecoverable Error. So when resetting the capi adapter through sysfs, make sure the PSL cache is flushed. It won't help if there are any active Process Elements on the card