Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-11-03 Thread Michael Ellerman
On Tue, 2015-11-03 at 09:17 +0100, Frederic Barrat wrote: > Le 03/11/2015 00:48, Ian Munsie a écrit : > > > > Looks like we managed to introduce the same bug twice (d'oh!), so we > > should probably split this into two separate patches: > > > > The bug in file.c has existed forever so the fix for

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-11-03 Thread Frederic Barrat
Le 03/11/2015 00:48, Ian Munsie a écrit : Excerpts from Michael Ellerman's message of 2015-11-02 11:53:45 +1100: On Thu, 2015-10-29 at 13:39 +0100, Frederic Barrat wrote: When the cxl driver creates a context, it stores the pid of the calling task, incrementing the reference count on the str

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-11-02 Thread Michael Ellerman
On Tue, 2015-11-03 at 10:48 +1100, Ian Munsie wrote: > Excerpts from Michael Ellerman's message of 2015-11-02 11:53:45 +1100: > > On Thu, 2015-10-29 at 13:39 +0100, Frederic Barrat wrote: > > > > > When the cxl driver creates a context, it stores the pid of the > > > calling task, incrementing the

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-11-02 Thread Ian Munsie
Excerpts from Michael Ellerman's message of 2015-11-02 11:53:45 +1100: > On Thu, 2015-10-29 at 13:39 +0100, Frederic Barrat wrote: > > > When the cxl driver creates a context, it stores the pid of the > > calling task, incrementing the reference count on the struct > > pid. Current code mistakenly

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-11-01 Thread Michael Ellerman
On Thu, 2015-10-29 at 13:39 +0100, Frederic Barrat wrote: > When the cxl driver creates a context, it stores the pid of the > calling task, incrementing the reference count on the struct > pid. Current code mistakenly increments the reference count twice, > once through get_task_pid(), once throug

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-10-29 Thread Ian Munsie
Acked-by: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: Fix reference count on struct pid when attaching

2015-10-29 Thread Andrew Donnellan
On 29/10/15 23:39, Frederic Barrat wrote: When the cxl driver creates a context, it stores the pid of the calling task, incrementing the reference count on the struct pid. Current code mistakenly increments the reference count twice, once through get_task_pid(), once through get_pid(). The refere

[PATCH] cxl: Fix reference count on struct pid when attaching

2015-10-29 Thread Frederic Barrat
When the cxl driver creates a context, it stores the pid of the calling task, incrementing the reference count on the struct pid. Current code mistakenly increments the reference count twice, once through get_task_pid(), once through get_pid(). The reference count is only decremented once on detach