Re: [PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-12-21 Thread Greg KH
On Thu, Dec 21, 2017 at 09:36:19AM +0530, Vaibhav Jain wrote: > commit 12841f87b7a8ceb3d54f171660f72a86941bfcb3 upstream, for 4.3. Thanks, now applied to 4.4. greg k-h

[PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-12-20 Thread Vaibhav Jain
commit 12841f87b7a8ceb3d54f171660f72a86941bfcb3 upstream, for 4.3. During an eeh a kernel-oops is reported if no vPHB is allocated to the AFU. This happens as during AFU init, an error in creation of vPHB is a non-fatal error. Hence afu->phb should always be checked for NULL before iterating over

Re: [PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-12-20 Thread Vaibhav Jain
Greg KH writes: > On Wed, Dec 20, 2017 at 03:07:06PM +0530, Vaibhav Jain wrote: >> commit 12841f87b7a8ceb3d54f171660f72a86941bfcb3 upstream, for 4.9. > > Thanks, do we also need this for 4.4? If so, can you provide a > backport? > Thanks Greg for applying this patch on 4.9 stable tree. I have do

Re: [PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-12-20 Thread Greg KH
On Wed, Dec 20, 2017 at 03:07:06PM +0530, Vaibhav Jain wrote: > commit 12841f87b7a8ceb3d54f171660f72a86941bfcb3 upstream, for 4.9. Thanks, do we also need this for 4.4? If so, can you provide a backport? thanks, greg k-h

[PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-12-20 Thread Vaibhav Jain
commit 12841f87b7a8ceb3d54f171660f72a86941bfcb3 upstream, for 4.9. During an eeh a kernel-oops is reported if no vPHB is allocated to the AFU. This happens as during AFU init, an error in creation of vPHB is a non-fatal error. Hence afu->phb should always be checked for NULL before iterating over

Re: [PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-11-21 Thread Vaibhav Jain
Andrew Donnellan writes: > Looks to me like we might need the same fix in > cxl_vphb_error_detected()? It's called twice in > cxl_pci_error_detected(), and in only one of those cases is it > surrounded by an afu->phb NULL check. Thanks for catching this. Will send a v2 with update. -- Vaibh

Re: [PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-11-21 Thread Andrew Donnellan
On 22/11/17 16:46, Vaibhav Jain wrote: During an eeh a kernel-oops is reported if no vPHB to allocated to the AFU. This happens as during AFU init, an error in creation of vPHB is a non-fatal error. Hence afu->phb should always be checked for NULL before iterating over it for the virtual AFU pci

[PATCH] cxl: Check if vphb exists before iterating over AFU devices

2017-11-21 Thread Vaibhav Jain
During an eeh a kernel-oops is reported if no vPHB to allocated to the AFU. This happens as during AFU init, an error in creation of vPHB is a non-fatal error. Hence afu->phb should always be checked for NULL before iterating over it for the virtual AFU pci devices. This patch fixes the kenel-oops