Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Michel Dänzer
On Mon, 2012-06-25 at 10:20 +0100, David Laight wrote: > > > > Fine with me, though FWIW that not only doesn't use > > > > __constant_cpu_to_le16() but actually swaps the non-constant value. > > > > > > Don't see what point you are trying to make here. Swapping the value > > > from the actual com

RE: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread David Laight
> > > Fine with me, though FWIW that not only doesn't use > > > __constant_cpu_to_le16() but actually swaps the non-constant value. > > > > Don't see what point you are trying to make here. Swapping the value > > from the actual command structure is always fine with me. > > The point is that th

Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Andrei Emeltchenko
Hi Michel, On Mon, Jun 25, 2012 at 09:32:50AM +0200, Michel Dänzer wrote: > > > Also, it would have been nice if that fix was promoted to stable, so I > > > wouldn't have had to spend a good part of the weekend bisecting... > > > > Thinks like this happen. However after you bisected the issue you

Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Michel Dänzer
On Mon, 2012-06-25 at 00:22 -0700, Marcel Holtmann wrote: > Hi Michel, > > > > > Fixes built-in Bluetooth not working on Apple PowerBooks, regression > > > > from > > > > commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init > > > > sequence > > > > for some CSR based controller

Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Marcel Holtmann
Hi Michel, > > > Fixes built-in Bluetooth not working on Apple PowerBooks, regression from > > > commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init > > > sequence > > > for some CSR based controllers'). > > > > > > Cc: sta...@vger.kernel.org [v3.4] > > > Signed-off-by: Michel

Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Michel Dänzer
On Son, 2012-06-24 at 23:51 -0700, Marcel Holtmann wrote: > Hi Michel, > > > Fixes built-in Bluetooth not working on Apple PowerBooks, regression from > > commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init > > sequence > > for some CSR based controllers'). > > > > Cc: sta...@

Re: [PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-25 Thread Marcel Holtmann
Hi Michel, > Fixes built-in Bluetooth not working on Apple PowerBooks, regression from > commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init sequence > for some CSR based controllers'). > > Cc: sta...@vger.kernel.org [v3.4] > Signed-off-by: Michel Dänzer > --- > net/bluetooth/

[PATCH] bluetooth: opcode field of sent commands is little endian.

2012-06-24 Thread Michel Dänzer
Fixes built-in Bluetooth not working on Apple PowerBooks, regression from commit 75fb0e324daa48ec458fb5c2960eb07b80cfad9d ('Bluetooth: Fix init sequence for some CSR based controllers'). Cc: sta...@vger.kernel.org [v3.4] Signed-off-by: Michel Dänzer --- net/bluetooth/hci_core.c |2 +- 1 file