Re: [PATCH] block/swim3: Locking fixes

2011-12-12 Thread Jens Axboe
On 2011-12-12 05:57, Benjamin Herrenschmidt wrote: > The old PowerMac swim3 driver has some "interesting" locking issues, > using a private lock and failing to lock the queue before completing > requests, which triggered WARN_ONs among others. > > This rips out the private lock, makes everything o

[PATCH] block/swim3: Locking fixes

2011-12-11 Thread Benjamin Herrenschmidt
The old PowerMac swim3 driver has some "interesting" locking issues, using a private lock and failing to lock the queue before completing requests, which triggered WARN_ONs among others. This rips out the private lock, makes everything operate under the block queue lock, and generally makes things