Re: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

2017-10-25 Thread Michael Ellerman
Paul Mackerras writes: > On Wed, Oct 25, 2017 at 07:39:48AM +, Matthew Wilcox wrote: >> Hang on, don't tell me you found this by inspection. Are you not >> running the bitmap testcase, enabled by CONFIG_TEST_BITMAP? Either >> that should be producing an error, or there's a missing test case,

RE: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

2017-10-25 Thread Matthew Wilcox
From: Paul Mackerras [mailto:pau...@ozlabs.org] > On Wed, Oct 25, 2017 at 07:39:48AM +, Matthew Wilcox wrote: > > Hang on, don't tell me you found this by inspection. Are you not running > > the > bitmap testcase, enabled by CONFIG_TEST_BITMAP? Either that should be > producing an error, or

RE: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

2017-10-25 Thread Matthew Wilcox
: Paul Mackerras [mailto:pau...@ozlabs.org] > Sent: Wednesday, October 25, 2017 2:57 AM > To: Matthew Wilcox ; Linus Torvalds > ; l...@vger.kernel.org > Cc: linuxppc-...@ozlabs.org; linux-s...@vger.kernel.org > Subject: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian >

Re: [PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

2017-10-25 Thread Paul Mackerras
On Wed, Oct 25, 2017 at 07:39:48AM +, Matthew Wilcox wrote: > Hang on, don't tell me you found this by inspection. Are you not running the > bitmap testcase, enabled by CONFIG_TEST_BITMAP? Either that should be > producing an error, or there's a missing test case, or your inspection is > w

[PATCH] bitmap: Fix optimization of bitmap_set/clear for big-endian machines

2017-10-24 Thread Paul Mackerras
Commit 2a98dc028f91 ("include/linux/bitmap.h: turn bitmap_set and bitmap_clear into memset when possible", 2017-07-10) added an optimization which effectively assumes that a contiguous set of bits in a bitmap will be stored in a contiguous set of bytes of the bitmap, in the case where the starting