Re: [PATCH] atomic: add *_dec_not_zero

2011-05-08 Thread Mike Frysinger
On Sun, May 8, 2011 at 05:33, Sven Eckelmann wrote: > Russell King - ARM Linux wrote: > [...] >> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no >> generic header which it could be added to? > > Mike Frysinger already tried to answer it in > : >> that's what asm-generic i

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-08 Thread Benjamin Herrenschmidt
On Tue, 2011-05-03 at 23:30 +0200, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patche

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-08 Thread Russell King - ARM Linux
On Tue, May 03, 2011 at 11:30:35PM +0200, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-08 Thread Sven Eckelmann
Russell King - ARM Linux wrote: [...] > Do we need atomic_dec_not_zero() et.al. in every arch header - is there no > generic header which it could be added to? Mike Frysinger already tried to answer it in : > that's what asm-generic is for. if the arch isnt using it, it's > either because the ar

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Matt Turner
On Tue, May 3, 2011 at 5:30 PM, Sven Eckelmann wrote: > diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h > index e756d04..7e9434e 100644 > --- a/arch/alpha/include/asm/atomic.h > +++ b/arch/alpha/include/asm/atomic.h > @@ -200,6 +200,7 @@ static __inline__ int atomic_

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Will Deacon
On Tue, 2011-05-03 at 22:30 +0100, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patche

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread David Howells
Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches which may also want to use this

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread James Bottomley
On Wed, 2011-05-04 at 00:44 -0400, Mike Frysinger wrote: > On Tue, May 3, 2011 at 17:30, Sven Eckelmann wrote: > > Introduce an *_dec_not_zero operation. Make this a special case of > > *_add_unless because batman-adv uses atomic_dec_not_zero in different > > places like re-broadcast queue or aggr

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Geert Uytterhoeven
On Tue, May 3, 2011 at 23:30, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation.  Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches wh

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Chris Metcalf
On 5/3/2011 5:30 PM, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches which may al

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Ralf Baechle
On Tue, May 03, 2011 at 11:30:35PM +0200, Sven Eckelmann wrote: > arch/mips/include/asm/atomic.h |2 ++ > arch/mips/include/asm/local.h |1 + Acked-by: Ralf Baechle Ralf ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org ht

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Jesper Nilsson
On Tue, May 03, 2011 at 11:30:35PM +0200, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Mike Frysinger
On Wed, May 4, 2011 at 04:05, David Laight wrote: >> Introduce an *_dec_not_zero operation.  Make this a special case of >> *_add_unless because batman-adv uses atomic_dec_not_zero in different >> places like re-broadcast queue or aggregation queue management. There >> are other non-final patches w

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Sven Eckelmann
On Wednesday 04 May 2011 10:05:53 David Laight wrote: > > Introduce an *_dec_not_zero operation. Make this a special case of > > *_add_unless because batman-adv uses atomic_dec_not_zero in different > > places like re-broadcast queue or aggregation queue management. There > > are other non-final p

RE: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread David Laight
> Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches which may also want to use this macro. Isn't there a

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-04 Thread Ingo Molnar
* Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches which may also want to use t

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-03 Thread David Miller
From: Sven Eckelmann Date: Tue, 3 May 2011 23:30:35 +0200 > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final pa

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-03 Thread Mike Frysinger
On Tue, May 3, 2011 at 17:30, Sven Eckelmann wrote: > Introduce an *_dec_not_zero operation.  Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches whi

[PATCH] atomic: add *_dec_not_zero

2011-05-03 Thread Sven Eckelmann
Introduce an *_dec_not_zero operation. Make this a special case of *_add_unless because batman-adv uses atomic_dec_not_zero in different places like re-broadcast queue or aggregation queue management. There are other non-final patches which may also want to use this macro. Reported-by: David S. M