Re: [PATCH] arch/powerpc/platforms/powermac/pic.c: move of_node_put

2008-09-21 Thread Benjamin Herrenschmidt
On Sun, 2008-09-21 at 13:01 +0200, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > It seems better to dereference master before decrementing the reference > count rather than afterwards. > > The problem was found using the following semantic match: > (http://www.emn.fr/x-info/coc

[PATCH] arch/powerpc/platforms/powermac/pic.c: move of_node_put

2008-09-21 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> It seems better to dereference master before decrementing the reference count rather than afterwards. The problem was found using the following semantic match: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ expression n,E; identifier fld; iterator I;