Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Grant Likely
On Fri, Apr 25, 2008 at 12:51 PM, Sascha Hauer <[EMAIL PROTECTED]> wrote: > On Fri, Apr 25, 2008 at 04:30:55PM +0100, Matt Sealey wrote: > > Can I make a suggestion for this chip support? > > > > On certain 5200 boards these devices are not usable since they are not > > connected. My concern is

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Sascha Hauer
On Fri, Apr 25, 2008 at 04:30:55PM +0100, Matt Sealey wrote: > Can I make a suggestion for this chip support? > > On certain 5200 boards these devices are not usable since they are not > connected. My concern is the Efika where we only have 2 wakeup and 1 simple > GPIO available on the board and ma

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Matt Sealey
Can I make a suggestion for this chip support? On certain 5200 boards these devices are not usable since they are not connected. My concern is the Efika where we only have 2 wakeup and 1 simple GPIO available on the board and maybe a few others with a bit of tweaking and messing around. Instead

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Sascha Hauer
On Fri, Apr 25, 2008 at 05:07:37PM +0400, Anton Vorontsov wrote: > On Thu, Apr 24, 2008 at 05:36:59PM +0200, Sascha Hauer wrote: > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > In the latest kernels the preferred way is to include , >

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Anton Vorontsov
On Thu, Apr 24, 2008 at 05:36:59PM +0200, Sascha Hauer wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include In the latest kernels the preferred way is to include , the patch introducing it was merged just recently, so few people know about it yet. --

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Anton Vorontsov
On Fri, Apr 25, 2008 at 12:53:33PM +0200, Sascha Hauer wrote: [...] > > > > As for the wide spans caused by gpt gpios, it is probably okay for > > now, but we can rework it to do something clever (like have a single > > registration for all gpt gpios) at a later date. > > I would rather teach the

[PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Sascha Hauer
This patch adds gpiolib support for mpc5200 SOCs. Changes since last submit: - fixed checkpatch warnings - use shadow variables for register accesses - make match tables const - Add documentation Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> --- Documentation/powerpc/mpc52xx-device-tree-bind

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Sascha Hauer
On Thu, Apr 24, 2008 at 12:45:49PM -0600, Grant Likely wrote: > On Thu, Apr 24, 2008 at 9:36 AM, Sascha Hauer <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > Feel free to comment on this. > > > > Sascha > > > > > > This patch adds gpiolib support for mpc5200 SOCs. I'm not sure > > whether it's a

Re: [PATCH] add gpiolib support for mpc5200

2008-04-25 Thread Stephen Rothwell
Hi Sascha, One small comment. On Thu, 24 Apr 2008 17:36:59 +0200 Sascha Hauer <[EMAIL PROTECTED]> wrote: > > +#include Never include , use > +static struct of_device_id mpc52xx_wkup_gpiochip_match[] = { const, please. OK, I lied about only one comment :-) > +static struct of_device_id mpc5

Re: [PATCH] add gpiolib support for mpc5200

2008-04-24 Thread Grant Likely
On Thu, Apr 24, 2008 at 9:36 AM, Sascha Hauer <[EMAIL PROTECTED]> wrote: > Hi all, > > Feel free to comment on this. > > Sascha > > > This patch adds gpiolib support for mpc5200 SOCs. I'm not sure > whether it's a good idea to make this optional via kconfig. > The gpt devices only support a si

Re: [PATCH] add gpiolib support for mpc5200

2008-04-24 Thread Grant Likely
On Thu, Apr 24, 2008 at 9:36 AM, Sascha Hauer <[EMAIL PROTECTED]> wrote: > Hi all, > > Feel free to comment on this. > > Sascha > > > This patch adds gpiolib support for mpc5200 SOCs. I'm not sure > whether it's a good idea to make this optional via kconfig. > The gpt devices only support a si

[PATCH] add gpiolib support for mpc5200

2008-04-24 Thread Sascha Hauer
Hi all, Feel free to comment on this. Sascha This patch adds gpiolib support for mpc5200 SOCs. I'm not sure whether it's a good idea to make this optional via kconfig. The gpt devices only support a single gpio. In the current of_gpio implementation each chip consumes 32 GPIOs which leads to hu