RE: [PATCH] Xilinx: hwicap: cleanup polling timeout.

2008-05-06 Thread Stephen Neuendorffer
ikely > Sent: Monday, May 05, 2008 1:01 PM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org > Subject: Re: [PATCH] Xilinx: hwicap: cleanup polling timeout. > > On Mon, May 5, 2008 at 12:20 PM, Stephen Neuendorffer > <[EMAIL PROTECTED]> wrote: > > In order to

Re: [PATCH] Xilinx: hwicap: cleanup polling timeout.

2008-05-05 Thread Grant Likely
On Mon, May 5, 2008 at 12:20 PM, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > In order to avoid polling forever if an error occurs, this driver > includes a timeout counter. However, in fast systems, this counter > wasn't high enough. This patch fixes the bug and also makes the > buffer-b

[PATCH] Xilinx: hwicap: cleanup polling timeout.

2008-05-05 Thread Stephen Neuendorffer
In order to avoid polling forever if an error occurs, this driver includes a timeout counter. However, in fast systems, this counter wasn't high enough. This patch fixes the bug and also makes the buffer-based and fifo-based drivers return the same error condition on a timeout (-EIO). Signed-off

Re: [PATCH] Xilinx: hwicap: cleanup

2008-02-25 Thread Jiri Slaby
On 02/25/2008 12:21 AM, Stephen Neuendorffer wrote: >>> @@ -549,8 +556,7 @@ static int hwicap_release(struct inode *inode, > struct file *file) >>> int i; >>> int status = 0; >>> >>> - if (down_interruptible(&drvdata->sem)) >>> - return -ERESTARTSYS; >>> +

RE: [PATCH] Xilinx: hwicap: cleanup

2008-02-24 Thread Stephen Neuendorffer
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Grant Likely > Sent: Saturday, February 23, 2008 10:17 PM > To: Stephen Neuendorffer > Cc: linuxppc-dev@ozlabs.org; git-dev; [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [PAT

Re: [PATCH] Xilinx: hwicap: cleanup

2008-02-23 Thread Grant Likely
Stephen, when you address these comments, please double check the lkml address. It was misspelled when you sent this patch. Cheers, g. On Sat, Feb 23, 2008 at 11:16 PM, Grant Likely <[EMAIL PROTECTED]> wrote: > On Mon, Feb 11, 2008 at 11:24 AM, Stephen Neuendorffer > <[EMAIL PROTECTED]> wrote:

Re: [PATCH] Xilinx: hwicap: cleanup

2008-02-23 Thread Grant Likely
On Mon, Feb 11, 2008 at 11:24 AM, Stephen Neuendorffer <[EMAIL PROTECTED]> wrote: > Fix some missing __user tags and incorrect section tags. > Convert semaphores to mutexes. > Make probed_devices re-entrancy and error condition safe. > Fix some backwards memcpys. > Some other minor cleanups. >

[PATCH] Xilinx: hwicap: cleanup

2008-02-11 Thread Stephen Neuendorffer
Fix some missing __user tags and incorrect section tags. Convert semaphores to mutexes. Make probed_devices re-entrancy and error condition safe. Fix some backwards memcpys. Some other minor cleanups. Use kerneldoc format. Signed-off-by: Stephen Neuendorffer <[EMAIL PROTECTED]> --- Grant, Since