Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread David Gibson
On Thu, Jun 26, 2008 at 05:48:01PM -1000, Mitch Bradley wrote: > > > David Gibson wrote: >> On Thu, Jun 26, 2008 at 05:28:42PM -1000, Mitch Bradley wrote: >> >>> David Gibson wrote: >>> On Thu, Jun 26, 2008 at 01:50:40PM -1000, Mitch Bradley wrote: >> [snip] >> > +

Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread Mitch Bradley
David Gibson wrote: On Thu, Jun 26, 2008 at 05:28:42PM -1000, Mitch Bradley wrote: David Gibson wrote: On Thu, Jun 26, 2008 at 01:50:40PM -1000, Mitch Bradley wrote: [snip] + const u_int32_t *propval; + u_int32_t addrcells = 0, sizecells = 0;

Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread David Gibson
On Thu, Jun 26, 2008 at 05:28:42PM -1000, Mitch Bradley wrote: > David Gibson wrote: >> On Thu, Jun 26, 2008 at 01:50:40PM -1000, Mitch Bradley wrote: [snip] >>> + const u_int32_t *propval; >>> + u_int32_t addrcells = 0, sizecells = 0; >>>int len; >>> >>>

Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread Mitch Bradley
David Gibson wrote: On Thu, Jun 26, 2008 at 01:50:40PM -1000, Mitch Bradley wrote: This patch modifes ofpart.c so the total size of NAND FLASH and the size of an individual partition can exceed 4GiB. It does so by decoding the "reg" property based on the values of "#address-cells" and "#si

Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread David Gibson
On Thu, Jun 26, 2008 at 01:50:40PM -1000, Mitch Bradley wrote: > This patch modifes ofpart.c so the total size of NAND FLASH > and the size of an individual partition can exceed 4GiB. It does so > by decoding the "reg" property based on the values of "#address-cells" > and "#size-cells" in the par

Re: [PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread Mitch Bradley
A revised version of the patch, addressing some points that Segher identified, will be issued soon. So if you want to review the patch as submitted, please be aware that some stylistic things have already been fixed (u64 instead of u_int64_t etc, use of of_read_number(), removal of fallback code

[PATCH] Support NAND partitions >4GiB with Open Firmware

2008-06-26 Thread Mitch Bradley
This patch modifes ofpart.c so the total size of NAND FLASH and the size of an individual partition can exceed 4GiB. It does so by decoding the "reg" property based on the values of "#address-cells" and "#size-cells" in the parent node, thus allowing the base address and size to be 64-bit numbers