Re: [PATCH] Sam440ep support

2008-05-22 Thread Giuseppe Coviello
Il giorno mar, 20/05/2008 alle 08.34 -0500, Josh Boyer ha scritto: > On Tue, 20 May 2008 07:50:28 -0500 > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > On Mon, 19 May 2008 17:20:47 +0200 > > Giuseppe Coviello <[EMAIL PROTECTED]> wrote: > > > > > > > + [EMAIL PROTECTED] { > > > +

Re: [PATCH] Sam440ep support

2008-05-20 Thread Josh Boyer
On Tue, 20 May 2008 07:50:28 -0500 Josh Boyer <[EMAIL PROTECTED]> wrote: > On Mon, 19 May 2008 17:20:47 +0200 > Giuseppe Coviello <[EMAIL PROTECTED]> wrote: > > > > + [EMAIL PROTECTED] { > > + compatible = "ohci-be"; > > + reg

Re: [PATCH] Sam440ep support

2008-05-20 Thread Josh Boyer
On Mon, 19 May 2008 17:20:47 +0200 Giuseppe Coviello <[EMAIL PROTECTED]> wrote: > + [EMAIL PROTECTED] { > + compatible = "ohci-be"; > + reg = ; > + interrupts = <8 4 9 4>; > +

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-20 Thread Takashi Iwai
At Mon, 19 May 2008 19:23:10 +0200, Giuseppe Coviello wrote: > > On mer, 14/05/2008 14.26 +0200, Takashi Iwai wrote: > [cut] > > OK, here is another patch for testing. Since I lost my old patch > > somewhere (and it's not worth to dig the archive), I wrote it up > > quickly from scratch. This ve

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-19 Thread Giuseppe Coviello
On mer, 14/05/2008 14.26 +0200, Takashi Iwai wrote: [cut] > OK, here is another patch for testing. Since I lost my old patch > somewhere (and it's not worth to dig the archive), I wrote it up > quickly from scratch. This version should cover both SG and non-SG > buffers. It's against the latest

Re: [PATCH] Sam440ep support

2008-05-19 Thread Josh Boyer
On Tue, 6 May 2008 18:37:57 +0200 "Giuseppe Coviello" <[EMAIL PROTECTED]> wrote: > I've prepared another path to add the support for the sam440ep; > shortly I've merged arch/powerpc/boot/sam440ep.c in > arch/powerpc/boot/cuboot-sam440ep.c; I've inserted the code to make > the rtc works directly in

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Takashi Iwai
[EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], > > linuxppc-dev@ozlabs.org, [EMAIL PROTECTED] > > Betreff: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support) > > > At Tue, 06 May 2008 11:16:22 +0200, > > Gerhard Pircher wrote: > >

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Gerhard Pircher
PROTECTED] > Betreff: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support) > At Tue, 06 May 2008 11:16:22 +0200, > Gerhard Pircher wrote: > > > > Naturally I can do some tests, if you or Takashi come up with a new > > patch. > > OK, here is another p

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Gerhard Pircher
PROTECTED] > Betreff: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support) > At Tue, 06 May 2008 11:16:22 +0200, > Gerhard Pircher wrote: > > > > Naturally I can do some tests, if you or Takashi come up with a new > > patch. > > OK, here is another p

ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

2008-05-14 Thread Takashi Iwai
uxppc-dev@ozlabs.org, Takashi Iwai <[EMAIL PROTECTED]>, [EMAIL > > PROTECTED], [EMAIL PROTECTED] > > Betreff: Re: [PATCH] Sam440ep support > > > > > On Tue, 2008-05-06 at 09:51 +0200, Gerhard Pircher wrote: > > > Takashi Iwai posted a preliminary patch a lo

Re: [PATCH] Sam440ep support

2008-05-09 Thread Josh Boyer
On Fri, 9 May 2008 17:53:47 +0200 "Giuseppe Coviello" <[EMAIL PROTECTED]> wrote: > 2008/5/6 Giuseppe Coviello <[EMAIL PROTECTED]>: > > I've prepared another path to add the support for the sam440ep; > > shortly I've merged arch/powerpc/boot/sam440ep.c in > > arch/powerpc/boot/cuboot-sam440ep.c; I'

Re: [PATCH] Sam440ep support

2008-05-09 Thread Giuseppe Coviello
2008/5/6 Giuseppe Coviello <[EMAIL PROTECTED]>: > I've prepared another path to add the support for the sam440ep; > shortly I've merged arch/powerpc/boot/sam440ep.c in > arch/powerpc/boot/cuboot-sam440ep.c; I've inserted the code to make > the rtc works directly in arch/powerpc/platforms/44x/sam440

Re: [PATCH] Sam440ep support

2008-05-06 Thread Giuseppe Coviello
I've prepared another path to add the support for the sam440ep; shortly I've merged arch/powerpc/boot/sam440ep.c in arch/powerpc/boot/cuboot-sam440ep.c; I've inserted the code to make the rtc works directly in arch/powerpc/platforms/44x/sam440ep.c (so there isn't any arch/powerpc/sysdev/sam440ep.c

Re: [PATCH] Sam440ep support

2008-05-06 Thread Benjamin Herrenschmidt
On Tue, 2008-05-06 at 13:31 +0200, Takashi Iwai wrote: > > I don't think we can easily update the DMA API at this stage. What > we > > could do is provide a way to retrieve the struct page array from the > > result of dma_alloc_coherent... > > In most cases, it can be obtained via pfn_to_page(),

Re: [PATCH] Sam440ep support

2008-05-06 Thread Takashi Iwai
At Tue, 06 May 2008 21:25:53 +1000, Benjamin Herrenschmidt wrote: > > > On Tue, 2008-05-06 at 13:14 +0200, Takashi Iwai wrote: > > > sg allocations are usually lists of page, so virt_to_page shouldn't > > be a > > > problem in the first place, though we still need some way to get the > > > right

Re: [PATCH] Sam440ep support

2008-05-06 Thread Benjamin Herrenschmidt
> Hrm... the problem is that you aren't supposed to make up sglists with > the result of dma_alloc_coherent... It might be a limitation of our core > DMA API, but that's we have to deal with today.. > > If you're going to make up sglists and call vmap, you should allocate > pages with normal GFP.

Re: [PATCH] Sam440ep support

2008-05-06 Thread Benjamin Herrenschmidt
On Tue, 2008-05-06 at 13:14 +0200, Takashi Iwai wrote: > > sg allocations are usually lists of page, so virt_to_page shouldn't > be a > > problem in the first place, though we still need some way to get the > > right prot attributes. > > The problem is that ALSA SG buffer is composed from pages a

Re: [PATCH] Sam440ep support

2008-05-06 Thread Takashi Iwai
At Tue, 06 May 2008 20:12:27 +1000, Benjamin Herrenschmidt wrote: > > > On Tue, 2008-05-06 at 11:16 +0200, Gerhard Pircher wrote: > > I can't answer this question. *ducked* :-) Takashi? > > > > FYI: I posted the results of the test with Takashi's dma_mmap_coherent > > patch here: > > http://ozla

Re: [PATCH] Sam440ep support

2008-05-06 Thread Benjamin Herrenschmidt
On Tue, 2008-05-06 at 11:16 +0200, Gerhard Pircher wrote: > I can't answer this question. *ducked* :-) Takashi? > > FYI: I posted the results of the test with Takashi's dma_mmap_coherent > patch here: > http://ozlabs.org/pipermail/linuxppc-dev/2006-June/024078.html > > On the other side it looks

Re: [PATCH] Sam440ep support

2008-05-06 Thread Gerhard Pircher
PROTECTED] > Betreff: Re: [PATCH] Sam440ep support > > On Tue, 2008-05-06 at 09:51 +0200, Gerhard Pircher wrote: > > Takashi Iwai posted a preliminary patch a long time ago. I tested it > > on my machine and it failed with non coherent scatter-gather DMA > > allocations

Re: [PATCH] Sam440ep support

2008-05-06 Thread Benjamin Herrenschmidt
On Tue, 2008-05-06 at 09:51 +0200, Gerhard Pircher wrote: > Takashi Iwai posted a preliminary patch a long time ago. I tested it > on my > machine and it failed with non coherent scatter-gather DMA allocations > (I guess almost all ALSA PCI drivers use SG DMA?). How does Alsa allocate such SG ?

Re: [PATCH] Sam440ep support

2008-05-06 Thread Gerhard Pircher
Original-Nachricht > Datum: Tue, 06 May 2008 09:44:18 +1000 > Von: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > An: Gerhard Pircher <[EMAIL PROTECTED]> > CC: Kumar Gala <[EMAIL PROTECTED]>, [EMAIL PROTECTED], linuxppc-dev@ozlabs.org > Betr

Re: [PATCH] Sam440ep support

2008-05-05 Thread Sean MacLennan
On Tue, 06 May 2008 09:36:48 +1000 "Benjamin Herrenschmidt" <[EMAIL PROTECTED]> wrote: > The IBM IIC driver should already have an of_platform_device created > for it, so we can have here a generic driver for that chip that > instanciates itself based on it. No need to create a platform > device .

Re: [PATCH] Sam440ep support

2008-05-05 Thread Josh Boyer
On Tue, 06 May 2008 09:40:05 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Mon, 2008-05-05 at 13:54 -0500, Josh Boyer wrote: > > > +arch_initcall(sam440ep_i2c_of_init); > > > > Ok, now I'm confused as to why you aren't doing this in your platform > > file (which would make it sp

Re: [PATCH] Sam440ep support

2008-05-05 Thread Benjamin Herrenschmidt
On Mon, 2008-05-05 at 21:50 +0200, Gerhard Pircher wrote: > This is a (bad) hack that I also use on the AmigaOne to get the ALSA > sound > drivers working with DMA, because ALSA doesn't work with > dma-noncoherent.c. > The problem is the "nopage" mechanism, which fails with non coherent > DMA > al

Re: [PATCH] Sam440ep support

2008-05-05 Thread Benjamin Herrenschmidt
On Mon, 2008-05-05 at 13:54 -0500, Josh Boyer wrote: > > +arch_initcall(sam440ep_i2c_of_init); > > Ok, now I'm confused as to why you aren't doing this in your platform > file (which would make it specific, and therefore justify its > existence. I addition, that gets called on all platforms, not

Re: [PATCH] Sam440ep support

2008-05-05 Thread Benjamin Herrenschmidt
On Mon, 2008-05-05 at 13:27 -0500, Kumar Gala wrote: > On May 5, 2008, at 1:23 PM, Giuseppe Coviello wrote: > > > This patch adds the support for the sam440ep board. > > > > arch/powerpc/boot/Makefile |5 +- > > arch/powerpc/boot/cuboot-sam440ep.c | 35 + > > arch/pow

Re: [PATCH] Sam440ep support

2008-05-05 Thread Benjamin Herrenschmidt
I wonder about the way this is split between the platform file and this "sysdev" file. The platform file is so small (and similar to other platform files) that I wonder if we can move toward something aking to the 5200 simple platform, that is have one platform with a list of matches. Now, the s

Re: [PATCH] Sam440ep support

2008-05-05 Thread Gerhard Pircher
Original-Nachricht > Datum: Mon, 5 May 2008 13:27:28 -0500 > Von: Kumar Gala <[EMAIL PROTECTED]> > An: "Giuseppe Coviello" <[EMAIL PROTECTED]> > CC: linuxppc-dev@ozlabs.org > Betreff: Re: [PATCH] Sam440ep support > > On May 5

Re: [PATCH] Sam440ep support

2008-05-05 Thread Josh Boyer
On Mon, 5 May 2008 20:23:29 +0200 "Giuseppe Coviello" <[EMAIL PROTECTED]> wrote: > This patch adds the support for the sam440ep board. Urgh. Could you split this into a number of smaller patches, each with a proper commit message that doesn't break the build on its own? See some initial comment

Re: [PATCH] Sam440ep support

2008-05-05 Thread Kumar Gala
On May 5, 2008, at 1:23 PM, Giuseppe Coviello wrote: This patch adds the support for the sam440ep board. arch/powerpc/boot/Makefile |5 +- arch/powerpc/boot/cuboot-sam440ep.c | 35 + arch/powerpc/boot/dts/sam440ep.dts | 292 ++ arch/powerpc/boot/sam440