Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-31 Thread Thiago Jung Bauermann
Am Donnerstag, 31 März 2016, 13:53:11 schrieb Naveen N. Rao: > You should indent the above output -- in this specific case, the start > marker interferes with git am. > > Apart from that, I have tested this patch and kretprobe works fine. A > minor nit I had is that we end up with a non-dot functi

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-31 Thread Naveen N. Rao
On 2016/03/28 05:06PM, Thiago Jung Bauermann wrote: > Fixes the following testsuite failure: > > $ sudo ./perf test -v kallsyms > 1: vmlinux symtab matches kallsyms : > --- start --- > test child forked, pid 12489 > Using /proc/kcore for kernel object code > Looking at th

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-30 Thread Thiago Jung Bauermann
Am Mittwoch, 30 März 2016, 20:09:36 schrieb Michael Ellerman: > On Wed, 2016-03-30 at 13:34 +0530, Naveen N. Rao wrote: > > On 2016/03/29 08:35PM, Thiago Jung Bauermann wrote: > > > Am Dienstag, 29 März 2016, 14:31:34 schrieb Michael Ellerman: > > > > On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-30 Thread Michael Ellerman
On Wed, 2016-03-30 at 13:34 +0530, Naveen N. Rao wrote: > On 2016/03/29 08:35PM, Thiago Jung Bauermann wrote: > > Am Dienstag, 29 März 2016, 14:31:34 schrieb Michael Ellerman: > > > On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung Bauermann wrote: > > > > With this patch, all vmlinux symbols match /p

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-30 Thread Naveen N. Rao
On 2016/03/30 01:34PM, Naveen N Rao wrote: > On 2016/03/29 08:35PM, Thiago Jung Bauermann wrote: > > Am Dienstag, 29 März 2016, 14:31:34 schrieb Michael Ellerman: > > > On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung Bauermann wrote: > > So at first glance, it looks like perf is better off using sym

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-30 Thread Naveen N. Rao
On 2016/03/29 08:35PM, Thiago Jung Bauermann wrote: > Am Dienstag, 29 März 2016, 14:31:34 schrieb Michael Ellerman: > > On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung Bauermann wrote: > > > With this patch, all vmlinux symbols match /proc/kallsyms and the > > > testcase passes. > > > > Have you te

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-29 Thread Michael Ellerman
On Tue, 2016-03-29 at 15:34 -0300, Thiago Jung Bauermann wrote: > Am Dienstag, 29 März 2016, 10:45:57 schrieb Michael Ellerman: > > On Mon, 2016-03-28 at 17:29 -0300, Thiago Jung Bauermann wrote: > > > If I do s/_do_fork/._do_fork/ in kprobe_ftrace.tc then all ftrace kprobe > > > tests pass: > > >

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-29 Thread Thiago Jung Bauermann
Am Dienstag, 29 März 2016, 14:31:34 schrieb Michael Ellerman: > On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung Bauermann wrote: > > With this patch, all vmlinux symbols match /proc/kallsyms and the > > testcase passes. > > Have you tested this on an LE system? No, I was focusing on ppc64 BE. > I

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-29 Thread Thiago Jung Bauermann
Am Dienstag, 29 März 2016, 10:45:57 schrieb Michael Ellerman: > On Mon, 2016-03-28 at 17:29 -0300, Thiago Jung Bauermann wrote: > > If I do s/_do_fork/._do_fork/ in kprobe_ftrace.tc then all ftrace kprobe > > tests pass: > > OK. We fixed that in 'perf probe', but not if you're using the sysfs file

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-28 Thread Michael Ellerman
On Mon, 2016-03-28 at 17:06 -0300, Thiago Jung Bauermann wrote: > Fixes the following testsuite failure: > > $ sudo ./perf test -v kallsyms > 1: vmlinux symtab matches kallsyms : > --- start --- > test child forked, pid 12489 > Using /proc/kcore for kernel object code >

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-28 Thread Michael Ellerman
On Mon, 2016-03-28 at 17:29 -0300, Thiago Jung Bauermann wrote: > Am Montag, 28 März 2016, 17:06:32 schrieb Thiago Jung Bauermann: > > /home/bauermann/src/linux/tools/testing/selftests/ftrace/test.d/kprobe/kp > > robe_ftrace.tc: line 9: echo: write error: Invalid argument > > > > But even wit

Re: [PATCH] Remove kretprobe_trampoline_holder.

2016-03-28 Thread Thiago Jung Bauermann
Am Montag, 28 März 2016, 17:06:32 schrieb Thiago Jung Bauermann: > /home/bauermann/src/linux/tools/testing/selftests/ftrace/test.d/kprobe/kp > robe_ftrace.tc: line 9: echo: write error: Invalid argument > > But even without my patch that testcase fails in the same way, so this > is not a probl

[PATCH] Remove kretprobe_trampoline_holder.

2016-03-28 Thread Thiago Jung Bauermann
Fixes the following testsuite failure: $ sudo ./perf test -v kallsyms 1: vmlinux symtab matches kallsyms : --- start --- test child forked, pid 12489 Using /proc/kcore for kernel object code Looking at the vmlinux_path (8 entries long) Using /boot/vmlinux for symbols 0xc0