Re: [PATCH] PowerPC: const intspec pointers

2009-12-21 Thread Grant Likely
On Thu, Dec 17, 2009 at 5:55 AM, Roman Fietze wrote: > Hello Grant, > > On Tuesday 15 December 2009 20:50:05 Grant Likely wrote: > >> Yes, I'm using the driver in a couple of projects.  It works for me >> for both RX and TX (although TX+DMA has been troublesome). > > That's what I found out. > >>

Re: [PATCH] PowerPC: const intspec pointers

2009-12-17 Thread Roman Fietze
Hello Grant, On Tuesday 15 December 2009 20:50:05 Grant Likely wrote: > Yes, I'm using the driver in a couple of projects. It works for me > for both RX and TX (although TX+DMA has been troublesome). That's what I found out. > The test driver on the other hand is pretty poor code. Don't expec

Re: [PATCH] PowerPC: const intspec pointers

2009-12-15 Thread Grant Likely
On Tue, Dec 15, 2009 at 3:59 AM, Roman Fietze wrote: > Hallo Grant, > > On Friday 11 December 2009 07:13:45 Grant Likely wrote: > >> BTW, if you're interested, there is a driver for the SCLPC FIFO about >> to be merged into 2.6.33.  It's in Ben's tree waiting to be pulled >> into mainline. > > I'v

Re: [PATCH] PowerPC: const intspec pointers

2009-12-15 Thread Roman Fietze
Hallo Grant, On Friday 11 December 2009 07:13:45 Grant Likely wrote: > BTW, if you're interested, there is a driver for the SCLPC FIFO about > to be merged into 2.6.33. It's in Ben's tree waiting to be pulled > into mainline. I've had a "look" into it. This means I rewrote it in some parts to g

Re: [PATCH] PowerPC: const intspec pointers

2009-12-10 Thread Grant Likely
On Tue, Dec 8, 2009 at 5:39 AM, Roman Fietze wrote: > Hello, > > Writing a driver using SCLPC on the MPC5200B I detected, that the > intspec arrays to map irqs to Linux virq cannot be const, because the > mapping and xlate functions only take non const pointers. All those > functions do not modify

Re: [PATCH] PowerPC: const intspec pointers

2009-12-10 Thread Grant Likely
On Tue, Dec 8, 2009 at 7:45 PM, Benjamin Herrenschmidt wrote: > On Tue, 2009-12-08 at 13:39 +0100, Roman Fietze wrote: >> Hello, >> >> Writing a driver using SCLPC on the MPC5200B I detected, that the >> intspec arrays to map irqs to Linux virq cannot be const, because the >> mapping and xlate fun

Re: [PATCH] PowerPC: const intspec pointers

2009-12-08 Thread Benjamin Herrenschmidt
On Tue, 2009-12-08 at 13:39 +0100, Roman Fietze wrote: > Hello, > > Writing a driver using SCLPC on the MPC5200B I detected, that the > intspec arrays to map irqs to Linux virq cannot be const, because the > mapping and xlate functions only take non const pointers. All those > functions do not mod

[PATCH] PowerPC: const intspec pointers

2009-12-08 Thread Roman Fietze
Hello, Writing a driver using SCLPC on the MPC5200B I detected, that the intspec arrays to map irqs to Linux virq cannot be const, because the mapping and xlate functions only take non const pointers. All those functions do not modify the intspec, so a const pointer could be used. I tried to comp