On 2016/12/06 10:18PM, PrasannaKumar Muralidharan wrote:
> > By the way, I missed mentioning previously: please use 'powerpc: '
> > prefix for the subject, rather than PPC.
>
> I will change it. Wondering how they are different.
It's by convention. Maintainers are picky ;)
- Naveen
> By the way, I missed mentioning previously: please use 'powerpc: '
> prefix for the subject, rather than PPC.
I will change it. Wondering how they are different.
>> Add modsw and moduw instruction emulation support to analyse_instr.
>
> And, it will be better if you can briefly describe what th
> I guessed as much, but if you look at the existing function, you'll see
> that things have been arranged in numerical order. As such, it's best to
> stick to that convention.
Makes sense. Will do.
By the way, I missed mentioning previously: please use 'powerpc: '
prefix for the subject, rather than PPC.
On 2016/12/04 10:25PM, PrasannaKumar Muralidharan wrote:
> Add modsw and moduw instruction emulation support to analyse_instr.
And, it will be better if you can briefly describe what thes
On 2016/12/06 01:21AM, PrasannaKumar Muralidharan wrote:
> >> +
> >> + case 267: /* moduw */
> >
> > Please move this case further up so that the extended opcodes are in
> > numerical order.
>
> Placed it after divide instruction as it appeared logical. Also placed
> 267 below 77
Hi Naveen,
Thanks for the review.
>> ---
>> arch/powerpc/lib/sstep.c | 9 +
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
>> index 9c78a9c..5acef72 100644
>> --- a/arch/powerpc/lib/sstep.c
>> +++ b/arch/powerpc/lib/sstep.c
>> @@
On 2016/12/04 10:25PM, PrasannaKumar Muralidharan wrote:
> Add modsw and moduw instruction emulation support to analyse_instr.
>
> Signed-off-by: PrasannaKumar Muralidharan
Hi Prasanna,
Thanks for the patch! A few minor comments below...
> ---
> arch/powerpc/lib/sstep.c | 9 +
> 1 file
Add modsw and moduw instruction emulation support to analyse_instr.
Signed-off-by: PrasannaKumar Muralidharan
---
arch/powerpc/lib/sstep.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index 9c78a9c..5acef72 100644
--- a/arch/pow
