Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

2008-07-02 Thread Kumar Gala
On Jun 27, 2008, at 3:01 PM, Nye Liu wrote: From: Nye Liu <[EMAIL PROTECTED]> udbg_putc is a *function pointer* that is initialized during udbg_init_cpm. It might not be initialized properly when called from udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. Printing an "X" on i

[PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

2008-06-27 Thread Nye Liu
From: Nye Liu <[EMAIL PROTECTED]> udbg_putc is a *function pointer* that is initialized during udbg_init_cpm. It might not be initialized properly when called from udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. Printing an "X" on initialization is ugly. How about a "\n" instead?

Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc

2008-06-27 Thread Scott Wood
Nye Liu wrote: udbg_putc is a *function pointer* that is initialized during udbg_init_cpm. It might not be initialized properly when called from udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. ACK Printing an "X" on initialization is ugly. How about a "\n" instead? D'oh, th