Re: [PATCH] POWERPC: add support of the GiGE switch for mpc8313RDB via fixed PHY

2007-07-17 Thread Vitaly Bordug
On Tue, 17 Jul 2007 11:43:31 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > This just comments on code style, not semantics... I agree with Segher > that this isn't the way to do it. That's nm, I'll rather include specific field into mac node, so the function below will be rewritten. -- Sincere

Re: [PATCH] POWERPC: add support of the GiGE switch for mpc8313RDB via fixed PHY

2007-07-17 Thread Scott Wood
This just comments on code style, not semantics... I agree with Segher that this isn't the way to do it. On Tue, Jul 17, 2007 at 04:49:37AM +0400, Vitaly Bordug wrote: > +#if defined(CONFIG_FIXED_MII_1000_FDX) > + > +static int fixed_set_link (void) > +{ > + struct fixed_info *phyinfo = fixed

Re: [PATCH] POWERPC: add support of the GiGE switch for mpc8313RDB via fixed PHY

2007-07-17 Thread Segher Boessenkool
> This utilises pretend phy, making access to it via device tree. > GiGE switch > is connected to TSEC1 with fixed gigE link, so we need to emulate it > via artificial PHY to make it work. Even if "pretend phy" in the device tree would be a good idea (and it's not)... > #s

[PATCH] POWERPC: add support of the GiGE switch for mpc8313RDB via fixed PHY

2007-07-16 Thread Vitaly Bordug
This utilises pretend phy, making access to it via device tree. GiGE switch is connected to TSEC1 with fixed gigE link, so we need to emulate it via artificial PHY to make it work. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8313erdb.dts |1 + arch/pow