Re: [PATCH] OF device tree: Move of_get_mac_address() to a common source file.

2010-11-01 Thread Grant Likely
On Mon, Nov 1, 2010 at 11:46 AM, Timur Tabi wrote: > On Mon, Nov 1, 2010 at 12:17 AM, Grant Likely > wrote: > >> Applied, thanks; but made some changes to protect this code because it >> does not work on little endian (it can be fixed in a separate patch) > > I'm confused.  How does of_get_mac_a

Re: [PATCH] OF device tree: Move of_get_mac_address() to a common source file.

2010-11-01 Thread Timur Tabi
On Mon, Nov 1, 2010 at 12:17 AM, Grant Likely wrote: > Applied, thanks; but made some changes to protect this code because it > does not work on little endian (it can be fixed in a separate patch) I'm confused. How does of_get_mac_address() not work on little-endian? -- Timur Tabi Linux kerne

Re: [PATCH] OF device tree: Move of_get_mac_address() to a common source file.

2010-11-01 Thread Timur Tabi
On Mon, Nov 1, 2010 at 12:17 AM, Grant Likely wrote: >> Signed-off-by: David Daney >> Cc: Michal Simek >> Cc: Grant Likely >> Cc: Benjamin Herrenschmidt >> Cc: Wolfram Sang >> Cc: Paul Mackerras >> Cc: "David S. Miller" >> Cc: Corey Minyard >> Cc: Pantelis Antoniou >> Cc: Vitaly Bordug

Re: [PATCH] OF device tree: Move of_get_mac_address() to a common source file.

2010-10-31 Thread Grant Likely
On Tue, Oct 26, 2010 at 03:07:13PM -0700, David Daney wrote: > There are two identical implementations of of_get_mac_address(), one > each in arch/powerpc/kernel/prom_parse.c and > arch/microblaze/kernel/prom_parse.c. Move this function to a new > common file of_net.{c,h} and adjust all the caller

[PATCH] OF device tree: Move of_get_mac_address() to a common source file.

2010-10-26 Thread David Daney
There are two identical implementations of of_get_mac_address(), one each in arch/powerpc/kernel/prom_parse.c and arch/microblaze/kernel/prom_parse.c. Move this function to a new common file of_net.{c,h} and adjust all the callers to include the new header. Signed-off-by: David Daney Cc: Michal