Re: [PATCH] MPC5121 FEC support

2008-06-17 Thread John Rigby
On Tue, Jun 17, 2008 at 6:35 PM, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > Hi John, > > You should factor out the fec_t -> struct fec change into an earlier > patch of its own. Ok, I'll separate that from the checkpatch fixes. > > > On Tue, 17 Jun 2008 11:48:00 -0600 John Rigby <[EMAIL PROTE

Re: [PATCH] MPC5121 FEC support

2008-06-17 Thread Stephen Rothwell
Hi John, You should factor out the fec_t -> struct fec change into an earlier patch of its own. On Tue, 17 Jun 2008 11:48:00 -0600 John Rigby <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/net/fs_enet/fec_mpc5121.h > +#include Nothing in this file uses anything in asm/cpm.h, so it shouldn't be i

Re: [PATCH] MPC5121 FEC support

2008-06-17 Thread Scott Wood
This patch should go through Jeff Garzik and be CCed to [EMAIL PROTECTED] John Rigby wrote: drivers/net/fs_enet/fs_enet-main.c Add a routine for conditionally copying TX skb's that are not aligned. Only do this if fep->fpi->align_tx_packets is set. In fs_enet_probe set fpi->a

[PATCH] MPC5121 FEC support

2008-06-17 Thread John Rigby
Add support for MPC512x to fs_enet driver NOTE: This patch is not perfect, there are still some CONFIG_CPM1 ifdefs. But there it should support multiplatform kernels since CPM2 and FEC are mutually exclusive. arch/powerpc/boot/dts/mpc5121ads.dts Fix a typo in the file header and add ethern