On Wed, 2008-12-10 at 19:53 -0500, Josh Boyer wrote:
>
> That's fine too. I think you can Michael can have a virtual
> arm-wrestling match to decide whether ppc_pci_has_flag or
> ppc_pci_flags_are_set wins ;)
I vote for _has_flag() :-)
I even wonder if we need the word "flag" in there at all, b
On Wed, 10 Dec 2008 16:17:13 -0800 (PST)
Trent Piepho <[EMAIL PROTECTED]> wrote:
> On Wed, 10 Dec 2008, Josh Boyer wrote:
> > On Thu, 11 Dec 2008 10:46:28 +1100
> >>> +#ifdef CONFIG_PCI
> >>> +extern unsigned int ppc_pci_flags;
> >>> +#define ppc_pci_set_flags(flags) ppc_pci_flags = (flags)
> >>>
On Thu, 11 Dec 2008 11:04:05 +1100
Michael Ellerman <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-12-10 at 18:54 -0500, Josh Boyer wrote:
> > On Thu, 11 Dec 2008 10:46:28 +1100
> > Michael Ellerman <[EMAIL PROTECTED]> wrote:
> >
> > > On Wed, 2008-12-10 at 14:11 -0500, Josh Boyer wrote:
> > > > Curre
On Wed, 10 Dec 2008, Josh Boyer wrote:
> On Thu, 11 Dec 2008 10:46:28 +1100
>>> +#ifdef CONFIG_PCI
>>> +extern unsigned int ppc_pci_flags;
>>> +#define ppc_pci_set_flags(flags) ppc_pci_flags = (flags)
>>> +#define ppc_pci_add_flags(flags) ppc_pci_flags |= (flags)
>>> +#define ppc_pci_flag_is_set(fl
On Wed, 2008-12-10 at 18:54 -0500, Josh Boyer wrote:
> On Thu, 11 Dec 2008 10:46:28 +1100
> Michael Ellerman <[EMAIL PROTECTED]> wrote:
>
> > On Wed, 2008-12-10 at 14:11 -0500, Josh Boyer wrote:
> > > Currently there are a number of platforms that open code access to
> > > the ppc_pci_flags global
On Thu, 11 Dec 2008 10:46:28 +1100
Michael Ellerman <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-12-10 at 14:11 -0500, Josh Boyer wrote:
> > Currently there are a number of platforms that open code access to
> > the ppc_pci_flags global variable. However, that variable is not
> > present if CONFIG_P
On Wed, 2008-12-10 at 14:11 -0500, Josh Boyer wrote:
> Currently there are a number of platforms that open code access to
> the ppc_pci_flags global variable. However, that variable is not
> present if CONFIG_PCI is not set, which can lead to a build break.
>
> This introduces a number of accesso
Currently there are a number of platforms that open code access to
the ppc_pci_flags global variable. However, that variable is not
present if CONFIG_PCI is not set, which can lead to a build break.
This introduces a number of accessor functions that are defined
to be empty in the case of CONFIG_
