Manish Ahuja writes:
> I presume the patch is good then. Do I need to change anything ?
I guess not. It will cause a warning on the first for loop if anyone
tries to compile with -Wextra or -Wsign-compare, but it would be only
one of lots of warnings in that case (and in fact comparing signed
wi
Paul Mackerras wrote:
> Andreas Schwab writes:
>
>
??? There is no rgn->cnt involved in the comparison.
>>> Look further down in lmb_add_region; there is a second for loop that
>>> does
>>>
>>> for (i = rgn->cnt-1; i >= 0; i--)
>>>
>> Which is exactly the one quoted
Andreas Schwab writes:
> >> ??? There is no rgn->cnt involved in the comparison.
> >
> > Look further down in lmb_add_region; there is a second for loop that
> > does
> >
> > for (i = rgn->cnt-1; i >= 0; i--)
>
> Which is exactly the one quoted above. I still don't see your point.
You're ri
Paul Mackerras <[EMAIL PROTECTED]> writes:
> Andreas Schwab writes:
>> Paul Mackerras <[EMAIL PROTECTED]> writes:
>>
>> > Manish Ahuja writes:
>> >
>> >> Repost to fix my email id.
>> >>
>> >> Fix to correct a possible infinite loop or an always true check when the
>> >> unsigned long counter "
Andreas Schwab writes:
> Paul Mackerras <[EMAIL PROTECTED]> writes:
>
> > Manish Ahuja writes:
> >
> >> Repost to fix my email id.
> >>
> >> Fix to correct a possible infinite loop or an always true check when the
> >> unsigned long counter "i" is used in
> >> lmb_add_region() in the following f
Paul Mackerras <[EMAIL PROTECTED]> writes:
> Manish Ahuja writes:
>
>> Repost to fix my email id.
>>
>> Fix to correct a possible infinite loop or an always true check when the
>> unsigned long counter "i" is used in
>> lmb_add_region() in the following for loop:
>>
>> for (i = rgn->cnt-1; i >=
Paul Mackerras wrote:
>> Fix to correct a possible infinite loop or an always true check when the
>> unsigned long counter "i" is used in
>> lmb_add_region() in the following for loop:
>> for (i = rgn->cnt-1; i >= 0; i--)
> Unfortunately this won't fix the bug. Since rgn->cnt is unsigned
> long,
Manish Ahuja writes:
> Repost to fix my email id.
>
> Fix to correct a possible infinite loop or an always true check when the
> unsigned long counter "i" is used in
> lmb_add_region() in the following for loop:
>
> for (i = rgn->cnt-1; i >= 0; i--)
Unfortunately this won't fix the bug. Since
Repost to fix my email id.
Fix to correct a possible infinite loop or an always true check when the
unsigned long counter "i" is used in
lmb_add_region() in the following for loop:
for (i = rgn->cnt-1; i >= 0; i--)
Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]>
---
arch/powerpc/mm/lmb.c |
Fix to correct a possible infinite loop or an always true check when the
unsigned long counter "i" is used in
lmb_add_region() in the following for loop:
for (i = rgn->cnt-1; i >= 0; i--)
Signed-off-by: Manish Ahuja <[EMAIL PROTECTED]>
---
arch/powerpc/mm/lmb.c |4 ++--
1 file changed, 2
10 matches
Mail list logo
