Re: [PATCH] Fix ext4 bitops

2008-02-04 Thread Geert Uytterhoeven
On Mon, 4 Feb 2008, Aneesh Kumar K.V wrote: > On Sun, Feb 03, 2008 at 01:39:02PM +0100, Geert Uytterhoeven wrote: > > On Sun, 3 Feb 2008, Heiko Carstens wrote: > > > On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote: > > > > On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote:

Re: [PATCH] Fix ext4 bitops

2008-02-04 Thread Aneesh Kumar K.V
On Mon, Feb 04, 2008 at 10:24:36AM +0100, Heiko Carstens wrote: > > > > > | fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy': > > > > > | fs/ext4/mballoc.c:954: error: implicit declaration of function > > > > > 'generic_find_next_le_bit' > > > > > > > > > > The s390 specific bitops uses pa

Re: [PATCH] Fix ext4 bitops

2008-02-04 Thread Heiko Carstens
> > > > | fs/ext4/mballoc.c: In function 'ext4_mb_generate_buddy': > > > > | fs/ext4/mballoc.c:954: error: implicit declaration of function > > > > 'generic_find_next_le_bit' > > > > > > > > The s390 specific bitops uses parts of the generic implementation. > > > > Include the correct header. > >

Re: [PATCH] Fix ext4 bitops

2008-02-03 Thread Aneesh Kumar K.V
On Fri, Feb 01, 2008 at 09:02:40PM +0100, Bastian Blank wrote: > Fix ext4 bitops. > > Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> > > diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h > index 220d9a7..d0980df 100644 > --- a/include/asm-powerpc/bitops.h > +++ b/include/

Re: [PATCH] Fix ext4 bitops

2008-02-03 Thread Aneesh Kumar K.V
On Sun, Feb 03, 2008 at 01:39:02PM +0100, Geert Uytterhoeven wrote: > On Sun, 3 Feb 2008, Heiko Carstens wrote: > > On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote: > > > On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote: > > > > On Fri, 1 Feb 2008 21:02:08 +0100 > > > > B

Re: [PATCH] Fix ext4 bitops

2008-02-03 Thread Geert Uytterhoeven
On Sun, 3 Feb 2008, Heiko Carstens wrote: > On Fri, Feb 01, 2008 at 10:04:04PM +0100, Bastian Blank wrote: > > On Fri, Feb 01, 2008 at 12:22:57PM -0800, Andrew Morton wrote: > > > On Fri, 1 Feb 2008 21:02:08 +0100 > > > Bastian Blank <[EMAIL PROTECTED]> wrote: > > > > > > > Fix ext4 bitops. > > >

Re: [PATCH] Fix ext4 bitops

2008-02-03 Thread Benjamin Herrenschmidt
On Fri, 2008-02-01 at 21:02 +0100, Bastian Blank wrote: > Fix ext4 bitops. Please provide a better description, as it's not obvious at first sight. > Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> > > diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h > index 220d9a7..d0

[PATCH] Fix ext4 bitops

2008-02-01 Thread Bastian Blank
Fix ext4 bitops. Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h index 220d9a7..d0980df 100644 --- a/include/asm-powerpc/bitops.h +++ b/include/asm-powerpc/bitops.h @@ -363,6 +363,8 @@ unsigned long generic_find_next_le_bit