Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-21 Thread Anton Blanchard
Hi Ian, > > > > Nice catch! I wonder if we should be checking for device_type > > > > "memory". Ben? > > > > > > Yes. That's what Linux does. > > > > Ian: I made that change, and slightly modified your commit message. > > Look ok? > > Looks good to me :) Excellent, I just pushed the fix. Anto

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-21 Thread Michael Neuling
On Wed, 2015-07-22 at 08:39 +0800, jer...@ozlabs.au.ibm.com wrote: > Hi Anton, > > > [PATCH] Fix crash due to processing "memory-controller" nodes as "memory" > > Looks good to me. If you apply this to your kexec-lite repo, I'll update > op-bu

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-21 Thread Jeremy Kerr
Hi Anton, > [PATCH] Fix crash due to processing "memory-controller" nodes as "memory" Looks good to me. If you apply this to your kexec-lite repo, I'll update op-build to use the new version, and send the merge requests for op-build. I'd expect we'd h

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-21 Thread Ian Munsie
Excerpts from Anton Blanchard's message of 2015-07-22 09:18:44 +1000: > Hi, > > > > Nice catch! I wonder if we should be checking for device_type > > > "memory". Ben? > > > > Yes. That's what Linux does. > > Ian: I made that change, and slightly modified your commit message. > Look ok? Looks go

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-21 Thread Anton Blanchard
Hi, > > Nice catch! I wonder if we should be checking for device_type > > "memory". Ben? > > Yes. That's what Linux does. Ian: I made that change, and slightly modified your commit message. Look ok? Anton -- [PATCH] Fix crash due to processing "memory

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-20 Thread Michael Ellerman
On Tue, 2015-07-21 at 12:45 +1000, Anton Blanchard wrote: > Hi Ian, > > > From: Ian Munsie > > > > If the system has a PCI device with a memory-controller device node, > > kexec-lite would spew hundreds of double free warnings and eventually > > segfault. This would result in a "kexec load faile

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-20 Thread Benjamin Herrenschmidt
On Tue, 2015-07-21 at 12:45 +1000, Anton Blanchard wrote: > Hi Ian, > > > From: Ian Munsie > > > > If the system has a PCI device with a memory-controller device node, > > kexec-lite would spew hundreds of double free warnings and eventually > > segfault. This would result in a "kexec load faile

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-20 Thread Anton Blanchard
Hi Ian, > From: Ian Munsie > > If the system has a PCI device with a memory-controller device node, > kexec-lite would spew hundreds of double free warnings and eventually > segfault. This would result in a "kexec load failed" message from > petitboot. > > This was due to kexec_memory_map() sea

Re: [PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-20 Thread Ian Munsie
Whoops - subject line was supposed to say "kexec-lite: ..." -Ian ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

2015-07-20 Thread Ian Munsie
From: Ian Munsie If the system has a PCI device with a memory-controller device node, kexec-lite would spew hundreds of double free warnings and eventually segfault. This would result in a "kexec load failed" message from petitboot. This was due to kexec_memory_map() searching for "memory" nodes