Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Jeff Garzik
Alexandre Bounine wrote: > From: Alexandre Bounine <[EMAIL PROTECTED]> > > This patch improves performance of the Tsi108 Ethernet driver by > changing interrupt handling for frame receive path. It reduces number of > interrupts generated for received frames and therefore lowers CPU > utilization b

[PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Alexandre Bounine
From: Alexandre Bounine <[EMAIL PROTECTED]> This patch improves performance of the Tsi108 Ethernet driver by changing interrupt handling for frame receive path. It reduces number of interrupts generated for received frames and therefore lowers CPU utilization by the device driver. Signed-off-b

RE: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-16 Thread Alexandre Bounine
- From: Scott Wood [mailto:[EMAIL PROTECTED] Sent: Friday, July 13, 2007 4:33 PM To: Scott Wood Cc: Alexandre Bounine; linuxppc-dev@ozlabs.org Subject: Re: [PATCH] Fix Tsi108 ethernet driver performance Scott Wood wrote: > Wouldn't this cause latencies of up to a second in responding to &g

Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-13 Thread Scott Wood
Scott Wood wrote: > Wouldn't this cause latencies of up to a second in responding to > received packets? I'd think that would be considered excessive. > > And shouldn't NAPI be reducing the RX interrupt load anyway? Sorry, I missed that you reduced the interval to 20 ms. Still, a bit on the h

Re: [PATCH] Fix Tsi108 ethernet driver performance

2007-07-13 Thread Scott Wood
Alexandre Bounine wrote: > -/* If the RX ring has run out of memory, try periodically > - * to allocate some more, as otherwise poll would never > - * get called (apart from the initial end-of-queue condition). > - * > - * This is called once per second (by default) from the thread. > +/* tsi108_ch

[PATCH] Fix Tsi108 ethernet driver performance

2007-07-13 Thread Alexandre Bounine
From: Alexandre Bounine <[EMAIL PROTECTED]> This patch improves performance of the Tsi108 Ethernet driver by changing interrupt handling for frame receive path. It reduces number of interrupts generated for received frames and therefore lowers CPU utilization by the device driver. Signed-off-b