Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-14 Thread Borislav Petkov
On Tue, May 14, 2019 at 04:50:49PM +1000, Michael Ellerman wrote: > Looks good. I even booted it :) Cool, thanks! -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-13 Thread Michael Ellerman
Borislav Petkov writes: > On Fri, May 10, 2019 at 04:13:20PM +0200, Borislav Petkov wrote: >> On Fri, May 10, 2019 at 08:50:52PM +1000, Michael Ellerman wrote: >> > Yeah that looks better to me. I didn't think about the case where EDAC >> > core is modular. >> > >> > Do you want me to send a new

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-10 Thread Borislav Petkov
On Fri, May 10, 2019 at 04:13:20PM +0200, Borislav Petkov wrote: > On Fri, May 10, 2019 at 08:50:52PM +1000, Michael Ellerman wrote: > > Yeah that looks better to me. I didn't think about the case where EDAC > > core is modular. > > > > Do you want me to send a new patch? > > Nah, I'll fix it up.

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-10 Thread Borislav Petkov
On Fri, May 10, 2019 at 08:50:52PM +1000, Michael Ellerman wrote: > Yeah that looks better to me. I didn't think about the case where EDAC > core is modular. > > Do you want me to send a new patch? Nah, I'll fix it up. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid to

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-10 Thread Michael Ellerman
Borislav Petkov writes: > On Thu, May 09, 2019 at 04:55:34PM +0200, Borislav Petkov wrote: >> On Fri, May 10, 2019 at 12:52:05AM +1000, Michael Ellerman wrote: >> > Thanks. It would be nice if you could send it as a fix for 5.2, it's the >> > last thing blocking one of my allmodconfig builds. But

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-09 Thread Borislav Petkov
On Thu, May 09, 2019 at 04:55:34PM +0200, Borislav Petkov wrote: > On Fri, May 10, 2019 at 12:52:05AM +1000, Michael Ellerman wrote: > > Thanks. It would be nice if you could send it as a fix for 5.2, it's the > > last thing blocking one of my allmodconfig builds. But if you don't > > think it qual

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-09 Thread Borislav Petkov
On Fri, May 10, 2019 at 12:52:05AM +1000, Michael Ellerman wrote: > Thanks. It would be nice if you could send it as a fix for 5.2, it's the > last thing blocking one of my allmodconfig builds. But if you don't > think it qualifies as a fix that's fine too, it can wait. Sure, no problem. Will do a

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-09 Thread Michael Ellerman
Borislav Petkov writes: > On Mon, May 06, 2019 at 08:50:45AM +0200, Johannes Thumshirn wrote: >> Acked-by: Johannes Thumshirn > > Queued, thanks. Thanks. It would be nice if you could send it as a fix for 5.2, it's the last thing blocking one of my allmodconfig builds. But if you don't think it

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-08 Thread Borislav Petkov
On Mon, May 06, 2019 at 08:50:45AM +0200, Johannes Thumshirn wrote: > Acked-by: Johannes Thumshirn Queued, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-05 Thread Johannes Thumshirn
Acked-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key finger

[PATCH] EDAC, mpc85xx: Prevent building as a module

2019-05-02 Thread Michael Ellerman
The mpc85xx EDAC code can be configured as a module but then fails to build because it uses two unexported symbols: ERROR: ".pci_find_hose_for_OF_device" [drivers/edac/mpc85xx_edac_mod.ko] undefined! ERROR: ".early_find_capability" [drivers/edac/mpc85xx_edac_mod.ko] undefined! We don't want