Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

2012-04-18 Thread Jesper Juhl
On Wed, 18 Apr 2012, Valentin Ilie wrote: > Fixed some checkpatch warnings. (review) > Last patch didn't compile. > > Signed-off-by: Valentin Ilie I'm wondering why you don't address the last 4 warnings and 2 errors from checkpatch while you are at it... But, the changes you make here look fi

[PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

2012-04-18 Thread Valentin Ilie
Fixed some checkpatch warnings. (review) Last patch didn't compile. Signed-off-by: Valentin Ilie --- drivers/ps3/ps3av.c |9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c index a409fa0..636e618 100644 --- a/drivers/ps3/ps3av.

[PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

2012-04-17 Thread Valentin Ilie
Fixed some indenting problems. Signed-off-by: Valentin Ilie --- drivers/ps3/ps3av.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c index a409fa0..46136b0 100644 --- a/drivers/ps3/ps3av.c +++ b/drivers/ps3/ps3av.c @@ -25

Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings

2012-04-17 Thread Geert Uytterhoeven
On Tue, Apr 17, 2012 at 13:16, Valentin Ilie wrote: > diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c > index a409fa0..46136b0 100644 > --- a/drivers/ps3/ps3av.c > +++ b/drivers/ps3/ps3av.c > @@ -25,8 +25,8 @@ >  #include >  #include >  #include > +#include > > -#include NAK. It reall