Re: [PATCH] Correct PowerPC VDSO call frame info

2018-09-13 Thread Reza Arbab
On Fri, Sep 14, 2018 at 08:57:04AM +0930, Alan Modra wrote: There is control flow in __kernel_clock_gettime that reaches label 99 without saving lr in r12. CFI info however is interpreted by the unwinder without reference to control flow: It's a simple matter of "Execute all the CFI opcodes up t

Re: [PATCH] Correct PowerPC VDSO call frame info

2018-09-13 Thread Michael Neuling
Alan, Thanks for the patch... A few minor comments... > Re: [PATCH] Correct PowerPC VDSO call frame info Our convention is to add powerpc: to the start. ie [PATCH] powerpc: Correct VDSO call frame info or even: [PATCH] powerpc/vdso: Correct call frame info On Fri, 2018-09-14 at 08

[PATCH] Correct PowerPC VDSO call frame info

2018-09-13 Thread Alan Modra
There is control flow in __kernel_clock_gettime that reaches label 99 without saving lr in r12. CFI info however is interpreted by the unwinder without reference to control flow: It's a simple matter of "Execute all the CFI opcodes up to the current address". That means the unwinder thinks r12 co