Re: [PATCH] Add support for the nwp serial device

2008-11-23 Thread Benjamin Krill
* Andrew Morton | 2008-11-21 13:22:44 [-0800]: >(does a powerpc allmodconfig) > >drivers/serial/nwpserial.c:443: warning: data definition has no type or >storage class >drivers/serial/nwpserial.c:443: warning: type defaults to 'int' in declaration >of 'console_initcall' >drivers/serial/nwpserial

Re: [PATCH] Add support for the nwp serial device

2008-11-22 Thread Benjamin Herrenschmidt
On Thu, 2008-11-20 at 15:01 +0100, Arnd Bergmann wrote: > From: Benjamin Krill <[EMAIL PROTECTED]> > > This patch adds support for the nwp serial device which is connected to > a DCR bus. It uses the of_serial device driver to determine necessary > properties from the device tree. The supported de

Re: [PATCH] Add support for the nwp serial device

2008-11-21 Thread Andrew Morton
On Thu, 20 Nov 2008 15:01:23 +0100 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > This patch adds support for the nwp serial device which is connected to > a DCR bus. It uses the of_serial device driver to determine necessary > properties from the device tree. The supported device is added as serial >

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread David Gibson
On Fri, Nov 21, 2008 at 08:21:02AM +0100, Benjamin Krill wrote: > * David Gibson | 2008-11-21 11:35:45 [+1100]: > > > > >Uh.. registers as port number 84?? What's this random number about? > > > It's just the next free number in serial_core.h. Ah, right, sorry, those are type codes. Thought you

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread Benjamin Krill
* David Gibson | 2008-11-21 11:35:45 [+1100]: > >Uh.. registers as port number 84?? What's this random number about? > It's just the next free number in serial_core.h. Ben ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailma

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread David Gibson
On Thu, Nov 20, 2008 at 03:01:23PM +0100, Arnd Bergmann wrote: > From: Benjamin Krill <[EMAIL PROTECTED]> > > This patch adds support for the nwp serial device which is connected to > a DCR bus. It uses the of_serial device driver to determine necessary > properties from the device tree. The suppo

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread Benjamin Krill
Hi Josh, >What does 'NWP' stand for, and how is it different from a regular serial >port? Also, what platforms can this device be found on currently? > >Some of that should be included in the changelog, but I'm curious as well >too. NWP stands for network processor and it is part of the QPACE -

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread Josh Boyer
On Thu, 20 Nov 2008 16:20:54 +0100 Benjamin Krill <[EMAIL PROTECTED]> wrote: > Hi Josh, > > >What does 'NWP' stand for, and how is it different from a regular serial > >port? Also, what platforms can this device be found on currently? > > > >Some of that should be included in the changelog, but

Re: [PATCH] Add support for the nwp serial device

2008-11-20 Thread Josh Boyer
On Thu, Nov 20, 2008 at 03:01:23PM +0100, Arnd Bergmann wrote: >From: Benjamin Krill <[EMAIL PROTECTED]> > >This patch adds support for the nwp serial device which is connected to >a DCR bus. It uses the of_serial device driver to determine necessary >properties from the device tree. The supported

[PATCH] Add support for the nwp serial device

2008-11-20 Thread Arnd Bergmann
From: Benjamin Krill <[EMAIL PROTECTED]> This patch adds support for the nwp serial device which is connected to a DCR bus. It uses the of_serial device driver to determine necessary properties from the device tree. The supported device is added as serial port number 84. Signed-off-by: Benjamin K