Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Implement symmetric_channels and symmetric_samplebits

2013-12-04 Thread Nicolin Chen
On Wed, Dec 04, 2013 at 10:42:30AM +, Mark Brown wrote: > On Wed, Dec 04, 2013 at 03:27:03PM +0800, Nicolin Chen wrote: > > > Sir, shall we also implement these two to other drivers like codecs? > > I know this symmetry is a new feature and might be still immature. > > By implementing it might

Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Implement symmetric_channels and symmetric_samplebits

2013-12-04 Thread Mark Brown
On Wed, Dec 04, 2013 at 03:27:03PM +0800, Nicolin Chen wrote: > Sir, shall we also implement these two to other drivers like codecs? > I know this symmetry is a new feature and might be still immature. > By implementing it might bring some side effects. But meanwhile, it > would also allows us to

Re: [PATCH] ASoC: fsl_ssi: Implement symmetric_channels and symmetric_samplebits

2013-12-03 Thread Nicolin Chen
On Tue, Dec 03, 2013 at 02:58:33PM +, Mark Brown wrote: > On Tue, Dec 03, 2013 at 06:38:07PM +0800, Nicolin Chen wrote: > > Since we introduced symmetric_channels and symmetric_samplebits, we > > implement > > these two features to fsl_ssi so as to drop some no-more-needed code and > > make >

Re: [PATCH] ASoC: fsl_ssi: Implement symmetric_channels and symmetric_samplebits

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 06:38:07PM +0800, Nicolin Chen wrote: > Since we introduced symmetric_channels and symmetric_samplebits, we implement > these two features to fsl_ssi so as to drop some no-more-needed code and make > the driver neat and clean. Applied, thanks. signature.asc Description: D

[PATCH] ASoC: fsl_ssi: Implement symmetric_channels and symmetric_samplebits

2013-12-03 Thread Nicolin Chen
Since we introduced symmetric_channels and symmetric_samplebits, we implement these two features to fsl_ssi so as to drop some no-more-needed code and make the driver neat and clean. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 79 ++--- 1