Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-11 Thread Daniel Baluta
On Thu, Nov 7, 2019 at 8:54 AM S.j. Wang wrote: > > Hi > > > > Hi Shengjiu, > > > > Comments inline. > > > > On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang > > wrote: > > > > > > Audmix support two substream, When two substream start to run, the > > > trigger function may be called by two substream

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-10 Thread Shengjiu Wang
Hi On Sat, Nov 9, 2019 at 10:48 AM Nicolin Chen wrote: > > On Wed, Nov 06, 2019 at 03:27:45PM +0800, Shengjiu Wang wrote: > > Audmix support two substream, When two substream start > > to run, the trigger function may be called by two substream > > in same time, that the priv->tdms may be updated

Re: [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-08 Thread Nicolin Chen
On Wed, Nov 06, 2019 at 03:27:45PM +0800, Shengjiu Wang wrote: > Audmix support two substream, When two substream start > to run, the trigger function may be called by two substream > in same time, that the priv->tdms may be updated wrongly. > > The expected priv->tdms is 0x3, but sometimes the >

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-06 Thread S.j. Wang
Hi > > Hi Shengjiu, > > Comments inline. > > On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang > wrote: > > > > Audmix support two substream, When two substream start to run, the > > trigger function may be called by two substream in same time, that the > > priv->tdms may be updated wrongly. > > > >

Re: [alsa-devel] [PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-06 Thread Daniel Baluta
Hi Shengjiu, Comments inline. On Wed, Nov 6, 2019 at 9:30 AM Shengjiu Wang wrote: > > Audmix support two substream, When two substream start > to run, the trigger function may be called by two substream > in same time, that the priv->tdms may be updated wrongly. > > The expected priv->tdms is 0x

[PATCH] ASoC: fsl_audmix: Add spin lock to protect tdms

2019-11-05 Thread Shengjiu Wang
Audmix support two substream, When two substream start to run, the trigger function may be called by two substream in same time, that the priv->tdms may be updated wrongly. The expected priv->tdms is 0x3, but sometimes the result is 0x2, or 0x1. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fs