Re: [PATCH] AMCC Crypto4xx Device Driver v5

2009-01-28 Thread Herbert Xu
On Wed, Jan 28, 2009 at 09:41:56AM -0800, James Hsiao wrote: > > I will re submit the patch with proper changelog. > I had the change log this way is for the reviewer easy to see the > difference. But, I agree this is not proper for a newly created driver. Oh yeah I have nothing against the chang

Re: [PATCH] AMCC Crypto4xx Device Driver v5

2009-01-28 Thread James Hsiao
Hi Herbert, I will re submit the patch with proper changelog. I had the change log this way is for the reviewer easy to see the difference. But, I agree this is not proper for a newly created driver. Thanks James On Wed, 2009-01-28 at 14:59 +1100, Herbert Xu wrote: > On Mon, Jan 12, 2009 at 11:3

Re: [PATCH] AMCC Crypto4xx Device Driver v5

2009-01-27 Thread Herbert Xu
On Mon, Jan 12, 2009 at 11:30:50AM -0800, James Hsiao wrote: > This is the 5th submission of AMCC's security driver. > - remove aad support in build pd function, since we didn't release any > algorithm that use aead yet. > > - changed some hardcode value to #defines > > - changed local_irq_disabl