Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Stefan Roese
On Wednesday 07 April 2010 09:41:56 Benjamin Herrenschmidt wrote: > BTW. Stefan mentioned earlier that they had some fixes for that driver > in the Denx tree. Are those fixes now included in that variant ? Yes, from a first scan the fix I was referring to seems to be included. Cheers, Stefan

RE: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Rupjyoti Sarmah
...@vger.kernel.org; s...@denx.de; linuxppc-...@ozlabs.org Subject: Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02> On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. > +struct

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-07 Thread Benjamin Herrenschmidt
On Tue, 2010-04-06 at 11:16 -0400, Jeff Garzik wrote: > > +static irqreturn_t dma_dwc_interrupt(int irq, void *hsdev_instance) > > +{ > > + int chan; > > + u32 tfr_reg, err_reg; > > + > > + struct sata_dwc_device *hsdev = > > + (struct sata_dwc_device *) hsdev_instance; > >

Re: [PATCH] 460EX on-chip SATA driver < resubmission : 02>

2010-04-06 Thread Jeff Garzik
On 04/06/2010 07:41 AM, Rupjyoti Sarmah wrote: General comment: remove "inline" and let the compiler select those functions that need it. +struct sata_dwc_host_priv { + + void __iomem *scr_addr_sstatus; + u32 sata_dwc_sactive_issued; + u32 sata_dwc_sactive_queued; +