Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

2010-02-09 Thread Grant Likely
ar...@pobox.com; >> grant.lik...@secretlab.ca; >> jwbo...@linux.vnet.ibm.com; Sadanand Mutyala >> Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support >> >> Hi John, >> >> Sorry If I'm painting bike-sheds here, just one tiny tweak might b

RE: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

2010-02-09 Thread John Linn
com; Sadanand Mutyala > Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support > > Hi John, > > Sorry If I'm painting bike-sheds here, just one tiny tweak might be in > order to standardise your mutex_unlock exit path: > > > +static int xemacli

RE: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

2010-02-09 Thread John Linn
com; Sadanand Mutyala > Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support > > Hi John, > > Sorry If I'm painting bike-sheds here, just one tiny tweak might be in > order to standardise your mutex_unlock exit path: Hey John, I prefer burning down bike-s

Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

2010-02-09 Thread John Williams
Hi John, Sorry If I'm painting bike-sheds here, just one tiny tweak might be in order to standardise your mutex_unlock exit path: > +static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) > +{ > +       struct net_local *lp = bus->priv; > +       u32 ctrl_reg; > +       u32 rc;

[PATCH] [V3] net: emaclite: adding MDIO and phy lib support

2010-02-09 Thread John Linn
These changes add MDIO and phy lib support to the driver as the IP core now supports the MDIO bus. The MDIO bus and phy are added as a child to the emaclite in the device tree as illustrated below. mdio { #address-cells = <1>; #size-cells = <0>; phy0: p...@7 {