Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
nux.vnet.ibm.com; >> linux-fbdev-de...@lists.sourceforge.net; linuxppc- >> d...@ozlabs.org; akonova...@ru.mvista.com; adap...@gmail.com; Suneel Garapati >> Subject: Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and >> cleanup DCR >> >> On Wed, Apr

RE: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Stephen Neuendorffer
nova...@ru.mvista.com; adap...@gmail.com; Suneel Garapati > Subject: Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and > cleanup DCR > > On Wed, Apr 15, 2009 at 9:58 AM, Stephen Neuendorffer > wrote: > >> > -       rc = of_address_to_re

RE: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Stephen Neuendorffer
> > -       rc = of_address_to_resource(op->node, 0, &res); > > -       if (rc) { > > -               dev_err(&op->dev, "invalid address\n"); > > -               return rc; > > +       /* > > +        * To check whether the core is connected directly to DCR or PLB > > +        * interface and initi

Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
On Wed, Apr 15, 2009 at 9:58 AM, Stephen Neuendorffer wrote: >> > -       rc = of_address_to_resource(op->node, 0, &res); >> > -       if (rc) { >> > -               dev_err(&op->dev, "invalid address\n"); >> > -               return rc; >> > +       /* >> > +        * To check whether the core is

Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
On Tue, Apr 14, 2009 at 2:08 PM, John Linn wrote: > Added support for the new xps tft controller. The new core > has PLB interface support in addition to existing DCR interface. Good looking patch. A few more comments below. g. >  /* >  * Xilinx calls it "PLB TFT LCD Controller" though it can

[PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-14 Thread John Linn
Added support for the new xps tft controller. The new core has PLB interface support in addition to existing DCR interface. Removed platform device support as both MicroBlaze and PowerPC use device tree. Previously, the dcr interface was assumed to be used in mmio mode, and the register space of