pc-...@ozlabs.org;
> grant.lik...@secretlab.ca;
> > jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com;
> michal.si...@petalogix.com; jty...@cs.ucr.edu
> > Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
> >
> > From: Eric Dumazet
> > Da
i...@petalogix.com;
michal.si...@petalogix.com; jty...@cs.ucr.edu
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> From: Eric Dumazet
> Date: Mon, 05 Apr 2010 23:29:53 +0200
>
> > So, I ask, cant you use netdev_alloc_skb_ip_align() in this drive
From: Eric Dumazet
Date: Mon, 05 Apr 2010 23:29:53 +0200
> So, I ask, cant you use netdev_alloc_skb_ip_align() in this driver ?
Thanks to everyone for getting this patch into shape.
I applied version 4 of the patch to net-next-2.6, thanks!
___
Linuxpp
alogix.com; michal.si...@petalogix.com; John Tyner
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> Le mardi 06 avril 2010 à 12:53 -0600, Grant Likely a écrit :
>
> > Hold on BUFFER_ALIGN is being used to align the DMA buffer on a
> > cache line boun
Le mardi 06 avril 2010 à 12:53 -0600, Grant Likely a écrit :
> Hold on BUFFER_ALIGN is being used to align the DMA buffer on a
> cache line boundary. I don't think netdev_alloc_skb() makes any
> guarantees about how the start of the IP header lines up against cache
> line boundaries. The amo
i...@petalogix.com;
michal.si...@petalogix.com; John Tyner
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> On Tue, 2010-04-06 at 12:53 -0600, Grant Likely wrote:
>
> > Hold on BUFFER_ALIGN is being used to align the DMA buffer on a
>
ibm.com;
> john.willi...@petalogix.com; michal.si...@petalogix.com; John Tyner
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> On Tue, Apr 6, 2010 at 11:11 AM, John Linn wrote:
> >> -Original Message-
> >> From: Eric Dumazet [mailto:eric.duma.
On Tue, 2010-04-06 at 12:53 -0600, Grant Likely wrote:
> Hold on BUFFER_ALIGN is being used to align the DMA buffer on a
> cache line boundary. I don't think netdev_alloc_skb() makes any
> guarantees about how the start of the IP header lines up against cache
> line boundaries. The amount of
; grant.lik...@secretlab.ca;
>> jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com;
>> michal.si...@petalogix.com; John Tyner
>> Subject: RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>>
>> Le mardi 06 avril 2010 à 10:12 -0600, John Linn a écrit :
>> &g
On Mon, Apr 5, 2010 at 3:33 PM, John Linn wrote:
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
>> > +/* Align the IP data in the packet on word boundaries as MicroBlaze
>> > + * needs it.
>> > + */
>> > +
>> > #define XTE_ALIGN 32
>> > -#define BUFFER_ALIGN(adr) ((XTE_ALIGN - ((u32)
>
> Yes I see how it's used, but it only allows you to reserve 2 bytes in the skb
> with no options.
Really ? This would be a bug !
__alloc_skb() uses kmalloc(), this gives you the guarantee you want,
or maybe comment you wrote is not what is _really_ necessary ?
/* Align the IP data in
gix.com;
> michal.si...@petalogix.com; John Tyner
> Subject: RE: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> Le mardi 06 avril 2010 à 10:12 -0600, John Linn a écrit :
> > > -Original Message-
> > > From: Eric Dumazet [mailto:eric.duma...@gm
> > grant.lik...@secretlab.ca;
> > jwbo...@linux.vnet.ibm.com; john.willi...@petalogix.com;
> > michal.si...@petalogix.com; John Tyner
> > Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
> >
> > Le lundi 05 avril 2010 à 15:11 -0600, John L
gix.com;
> michal.si...@petalogix.com; John Tyner
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> Le lundi 05 avril 2010 à 15:11 -0600, John Linn a écrit :
> > This patch adds support for using the LL TEMAC Ethernet driver on
> > non-Virtex 5 platf
On Mon, 2010-04-05 at 15:33 -0600, John Linn wrote:
> > > +/* Align the IP data in the packet on word boundaries as MicroBlaze
> > > + * needs it.
> > > + */
> > > +
> > > #define XTE_ALIGN 32
> > > -#define BUFFER_ALIGN(adr) ((XTE_ALIGN - ((u32) adr)) % XTE_ALIGN)
> > > +#define BUFFER_ALIG
On Mon, Apr 5, 2010 at 3:11 PM, John Linn wrote:
> This patch adds support for using the LL TEMAC Ethernet driver on
> non-Virtex 5 platforms by adding support for accessing the Soft DMA
> registers as if they were memory mapped instead of solely through the
> DCR's (available on the Virtex 5).
>
gix.com;
> michal.si...@petalogix.com; John Tyner
> Subject: Re: [PATCH] [V3] Add non-Virtex5 support for LL TEMAC driver
>
> Le lundi 05 avril 2010 à 15:11 -0600, John Linn a écrit :
> > This patch adds support for using the LL TEMAC Ethernet driver on
> > non-Virtex 5 platf
Le lundi 05 avril 2010 à 15:11 -0600, John Linn a écrit :
> This patch adds support for using the LL TEMAC Ethernet driver on
> non-Virtex 5 platforms by adding support for accessing the Soft DMA
> registers as if they were memory mapped instead of solely through the
> DCR's (available on the Virte
This patch adds support for using the LL TEMAC Ethernet driver on
non-Virtex 5 platforms by adding support for accessing the Soft DMA
registers as if they were memory mapped instead of solely through the
DCR's (available on the Virtex 5).
The patch also updates the driver so that it runs on the Mi
19 matches
Mail list logo
